Skip to content

[supply] don't apply rollout when value 1 of when uploading and don't call promote or rollout methods when uploading #15668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2019
Merged

[supply] don't apply rollout when value 1 of when uploading and don't call promote or rollout methods when uploading #15668

merged 2 commits into from
Nov 20, 2019

Conversation

joshdholtz
Copy link
Member

Motivation and Context

Fixes #15645

When rollout of 1 was sent with an uploaded apk/bundle, supply would try to set this which would cause the client to 💥. No reason to rollout of 1 to the client if not rolling out.

Description

Fixes ☝️ and also not calling promote_track or update_rollout if apk/bundle is uploaded because update_track does it all for a new apk/bundle.

[supply] don't apply rollout when value 1 of when uploading and don't…
d854f54 
… call promot or rollout methods when uploading
@janpio janpio added the tool: supply upload_to_playstore label Nov 16, 2019
@joshdholtz joshdholtz changed the title [supply] don't apply rollout when value 1 of when uploading and don't call promot or rollout methods when uploading [supply] don't apply rollout when value 1 of when uploading and don't call promote or rollout methods when uploading Nov 20, 2019
@joshdholtz joshdholtz merged commit 1e081f4 into master Nov 20, 2019
@joshdholtz joshdholtz deleted the joshdholtz-fix-supply-with-rollout-of-1-when-uploading branch November 20, 2019 15:52
@fastlane-bot
Copy link

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Nov 22, 2019
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.137.0 🚀

@fastlane-bot fastlane-bot mentioned this pull request Nov 23, 2019
Closed
4 tasks
@fastlane fastlane locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes status: released tool: supply upload_to_playstore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Regression][Supply] Rollout to production to 100% is failing
4 participants
@joshdholtz @fastlane-bot @janpio @googlebot