Skip to content

[action] gradle: Add support for mapping.txt file #15597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2019
Merged

[action] gradle: Add support for mapping.txt file #15597

merged 1 commit into from
Nov 20, 2019

Conversation

nicolashaan
Copy link
Contributor

@nicolashaan nicolashaan commented Nov 5, 2019 •
edited
Loading

Pick mapping.txt files.
Those may be useful to upload to stores such as App Center or Playstore.
Paths are exposed in GRADLE_MAPPING_TXT_OUTPUT_PATH and
GRADLE_ALL_MAPPING_TXT_OUTPUT_PATHS following established practices in this action.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
    Some failure on existing tests (probably due to iOS environment not fully set up and unlikely related to this PR)
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

mapping.txt contains the mapping for obfuscated symbols in generated byte code.
It may be uploaded alongside .apk/.aab to stores or crash reporters to allow stack traces and crash reporting with clear symbols.
it can be used as input parameters for:
appcenter_upload(
mapping: lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH],
...
)
upload_to_play_store(
mapping: lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH],
...
)

Description

Provides GRADLE_MAPPING_TXT_OUTPUT_PATH and GRADLE_ALL_MAPPING_TXT_OUTPUT_PATHS shared values.

Testing Steps

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nicolashaan
Copy link
Contributor Author

@googlebot I signed it!

1 similar comment
@nicolashaan
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 5, 2019
@janpio
Copy link
Member

janpio commented Nov 5, 2019

Actions.lane_context used properly here @mollyIV?

[action] gradle: Add support for mapping.txt file
d89cb2a 
Pick `mapping.txt` files.
Those may be useful to upload to stores such as App Center or Playstore.
Paths are exposed in GRADLE_MAPPING_TXT_OUTPUT_PATH and
GRADLE_ALL_MAPPING_TXT_OUTPUT_PATHS following established practices in this action.
joshdholtz
joshdholtz approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! Thanks for adding this 😊

@joshdholtz joshdholtz force-pushed the gradle-output-mapping-txt-path branch from a75bc0d to d89cb2a Compare November 20, 2019 20:40
@joshdholtz joshdholtz merged commit 0b53763 into fastlane:master Nov 20, 2019
@fastlane-bot
Copy link

Hey @NicoEkino 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Nov 22, 2019
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.137.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolashaan @googlebot @janpio @fastlane-bot @joshdholtz