You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gave this a try, saw the expected diffs. given that this just exposes a kubectl subcommand without additional changes I’m inclined to say its okay without further testing. the change makes sense to me, and I can see myself using it - though I start to wonder at what point the growing number of targets yielded by the macro becomes more annoying than piping the build output to kubectl and calling whatever subcommand you want.
gave this a try, saw the expected diffs. given that this just exposes a kubectl subcommand without additional changes I’m inclined to say its okay without further testing. the change makes sense to me, and I can see myself using it - though I start to wonder at what point the growing number of targets yielded by the macro becomes more annoying than piping the build output to kubectl and calling whatever subcommand you want.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a .diff target for k8s_deploy
Description
Add to the list of generated targets for k8s_deploy so, in addition to .show and .delete, it also has .diff
Related Issue
Motivation and Context
As part of a CICD pipeline, or testing, I'd like to see and record what the diff is between source and what kubernetes is actually running.
How Has This Been Tested?
No. Can you point me to how to test this?
Types of changes
Checklist: