Skip to content

🌐 Add Korean translation for docs/ko/docs/advanced/sub-applications.md #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 12, 2025
Merged

🌐 Add Korean translation for docs/ko/docs/advanced/sub-applications.md #4543

merged 15 commits into from
Jun 12, 2025

Conversation

NinaHwang
Copy link
Contributor 

Test complete

related: #2017

@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (e5c27e2) 100.00%.

❗ Current head e5c27e2 differs from pull request most recent head 74545f0. Consider uploading reports for the commit 74545f0 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            master     #4543    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          540       531     -9     
  Lines        13969     13629   -340     
==========================================
- Hits         13969     13629   -340

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

📝 Docs preview for commit a86d43e at: https://620367d7c29d9f4fc882caf4--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

📝 Docs preview for commit 738d9f3 at: https://62036893a5c416486954e792--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

📝 Docs preview for commit 27f90af at: https://62036c257049d062bcd4685d--fastapi.netlify.app

peacekimjapan
peacekimjapan reviewed Apr 19, 2022
View reviewed changes
@github-actions
Copy link
Contributor

📝 Docs preview for commit 41ce0a0 at: https://625f6e913579061f7dc9bf7f--fastapi.netlify.app

tiangolo
tiangolo requested changes May 10, 2022
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Can you please remove the .DS_Store file?

@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations labels May 10, 2022
@github-actions github-actions bot mentioned this pull request May 10, 2022
Closed
@github-actions
Copy link
Contributor

📝 Docs preview for commit e5c27e2 at: https://627e25d36ca4434899045dbe--fastapi.netlify.app

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@joonas-yoon
translated by fastapi#4543
303f922
@tiangolo tiangolo changed the title 🌐 Add Korean translation for advanced/sub-applications.md 🌐 Add Korean translation for docs/ko/docs/advanced/sub-applications.md Jun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit 74545f0 at: https://649a1be8d1bbbc13f560f9af--fastapi.netlify.app

@tiangolo
Copy link
Member

Thank you! I'm still waiting for others to review this to be able to merge it, meanwhile, maybe you could help me review some of the other Korean translations, that way if they are approved by each other, I could merge them. 🤓

https://github.com/tiangolo/fastapi/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3Alang-ko+label%3Aawaiting-review

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit dc3137a at: https://74cb4fa2.fastapitiangolo.pages.dev

Modified Pages

peacekimjapan
peacekimjapan approved these changes Mar 30, 2025
View reviewed changes
Copy link

@peacekimjapan peacekimjapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

📝 Docs preview for commit 9ef7e2b at: https://9314f2d3.fastapitiangolo.pages.dev

Modified Pages

YuriiMotov
YuriiMotov requested changes Jun 5, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

📝 Docs preview for commit 38d5045 at: https://939b59d6.fastapitiangolo.pages.dev

Modified Pages

@YuriiMotov YuriiMotov self-requested a review June 5, 2025 09:01
hard-coders
hard-coders approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been created a long time ago. 🤣
LGTM!

@YuriiMotov YuriiMotov requested a review from tiangolo June 5, 2025 09:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

📝 Docs preview for commit b144320 at: https://da8f2e0b.fastapitiangolo.pages.dev

Modified Pages

sodaMelon
sodaMelon approved these changes Jun 12, 2025
View reviewed changes
Copy link

@sodaMelon sodaMelon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 (i m korean)

@sodaMelon
Copy link

hi @YuriiMotov @alejsdev , could check this PR?
I think it's time to merge.🎶 (well it's been a long time lol)

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 009d62d at: https://424d44e0.fastapitiangolo.pages.dev

Modified Pages

@YuriiMotov YuriiMotov merged commit 095dcc8 into fastapi:master Jun 12, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo approved these changes

@YuriiMotov YuriiMotov YuriiMotov approved these changes

+3 more reviewers

@hard-coders hard-coders hard-coders approved these changes

@peacekimjapan peacekimjapan peacekimjapan approved these changes

@sodaMelon sodaMelon sodaMelon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NinaHwang @tiangolo @sodaMelon @hard-coders @peacekimjapan @YuriiMotov