Skip to content

Conversation

bom1215
Copy link
Contributor

@bom1215 bom1215 commented Mar 14, 2025

Hello!

I encountered that the document of Lifespan was not translated in Korean.
So I translated the English document to Korean.

Korean ver : https://fastapi.tiangolo.com/ko/advanced/events/ -> To be changed
English ver: https://fastapi.tiangolo.com/advanced/events/ -> Reference

Since this is my first PR to FastAPI, I would greatly appreciate any feedback 🙇‍♀️

@github-actions github-actions bot added the lang-all Translations label Mar 14, 2025
Copy link
Contributor

@svlandeg svlandeg added lang-ko Korean translations awaiting-review labels Mar 18, 2025
@svlandeg svlandeg changed the title 🌐 Update Korean translation for docs/ko/docs/advanced/events.md 🌐 Update Korean translation for docs/ko/docs/advanced/events.md Mar 18, 2025
Copy link
Contributor

@Zerohertz Zerohertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// 블럭이 깨져서 수정 요청 드립니다!

bom1215 and others added 5 commits March 19, 2025 21:44
Co-authored-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (오효근) <ohg3417@gmail.com>
@bom1215
Copy link
Contributor Author

bom1215 commented Mar 19, 2025

/// 블럭이 깨져서 수정 요청 드립니다!

@Zerohertz 정말 감사드립니다!

Copy link
Contributor

@bom1215
Copy link
Contributor Author

bom1215 commented Apr 8, 2025

Could any Korean contributors check my translation? I would deeply appreciate it if someone approve my translation.🙏

@yes0ng @hard-coders @Limsunoh

@Limsunoh
Copy link
Contributor

Limsunoh commented Apr 9, 2025

LGTM!! 깨진것도 없고 번역도 잘 되어있습니다.

@bom1215
Copy link
Contributor Author

bom1215 commented Apr 14, 2025

LGTM!! 깨진것도 없고 번역도 잘 되어있습니다.

@Limsunoh 감사합니다!!

@bom1215
Copy link
Contributor Author

bom1215 commented Apr 14, 2025

@alejsdev Thank you for changing the label of this PR! Is there anything I can do for this to be merged?

@alejsdev alejsdev merged commit aa2bb3e into fastapi:master May 30, 2025
58 checks passed
@alejsdev
Copy link
Member

Thanks for your help and contribution! @bom1215 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants