Skip to content

Conversation

valentinDruzhinin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Feb 12, 2025
Copy link
Contributor

@alejsdev alejsdev changed the title Add ukrainian translation for path-params.md 🌐 Update Ukrainian translation for docs/uk/docs/tutorial/path-params.md Feb 12, 2025
@alejsdev alejsdev changed the title 🌐 Update Ukrainian translation for docs/uk/docs/tutorial/path-params.md 🌐 Add Ukrainian translation for docs/uk/docs/tutorial/path-params.md Feb 12, 2025
@alejsdev alejsdev added awaiting-review lang-vi Vietnamese translations labels Feb 12, 2025
@valentinDruzhinin
Copy link
Contributor Author

Hi @alejsdev could you please change lang-vi label on lang-uk? Because it's ukrainian translation.

@alejsdev alejsdev added lang-uk Ukrainian translations and removed lang-vi Vietnamese translations labels Feb 12, 2025
@rostik1410
Copy link
Contributor

@valentinDruzhinin awesome work. Same ask as for other PRs about Ви but not required because it already has 2 approves :)

@valentinDruzhinin valentinDruzhinin force-pushed the translation-uk/path-params branch from f60637a to 52c582d Compare February 18, 2025 21:54
Copy link
Contributor

@valentinDruzhinin
Copy link
Contributor Author

@valentinDruzhinin awesome work. Same ask as for other PRs about Ви but not required because it already has 2 approves :)

Thanks, added fix :)

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual @valentinDruzhinin this is looking good from a structural point of view. Thanks for all your hard work translating these pages! 🙏 🚀 🤩

valentinDruzhinin and others added 2 commits February 24, 2025 18:16
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Copy link
Contributor

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valentinDruzhinin! 🍰

And thanks all for the reviews ☕

@tiangolo tiangolo merged commit ee729d4 into fastapi:master Feb 28, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-uk Ukrainian translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants