Skip to content

Conversation

k94-ishi
Copy link
Contributor

@k94-ishi k94-ishi commented Feb 1, 2025

This PR is a translation of virtual-environments.md. I'm Japanese.

@github-actions github-actions bot added the lang-all Translations label Feb 1, 2025
@alejsdev alejsdev changed the title Add Japanese translation for docs/ja/docs/virtual-environments.md 🌐 Add Japanese translation for docs/ja/docs/virtual-environments.md Feb 1, 2025
@alejsdev alejsdev added lang-ja Japanese translations awaiting-review labels Feb 1, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Copy link

@maru0123-2004 maru0123-2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate all your hard work.
There are some typo or something to fix, I found.

Thank you for your contributing.

Copy link
Contributor

@k94-ishi
Copy link
Contributor Author

@maru0123-2004 Thank you for your review and suggestion! I have updated this PR accordingly.

Copy link

@maru0123-2004 maru0123-2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this again, and I can't find problem on it.
So I approved this.

Thank you for your great works!

@alejsdev alejsdev merged commit f806e03 into fastapi:master Mar 19, 2025
52 checks passed
@alejsdev
Copy link
Member

Thanks for contributing to FastAPI! @k94-ishi 🚀

And thanks for your review! @maru0123-2004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants