-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
๐ Add Korean translation for docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
#13257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ Add Korean translation for docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
#13257
Conversation
๐ Docs preview for commit c98f384 at: https://3d31c444.fastapitiangolo.pages.dev Modified Pages |
๐ Docs preview for commit ba47aee at: https://1192f04e.fastapitiangolo.pages.dev Modified Pages |
docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
|
||
/// note | ๊ธฐ์ ์ธ๋ถ์ฌํญ | ||
|
||
ํ์ด์ฌ์ <a href=โhttps://docs.python.org/3/library/contextlib.htmlโ class=โexternal-linkโ target=โ_blankโ>Context Managers</a> ๋๋ถ์ ์ด ๊ธฐ๋ฅ์ด ์๋ํฉ๋๋ค. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
Co-authored-by: Hyogeun Oh (์คํจ๊ทผ) <ohg3417@gmail.com>
|
||
์๋ฅผ ๋ค์ด, ์ด ๊ธฐ๋ฅ์ ์ฌ์ฉํ๋ฉด ๋ฐ์ดํฐ๋ฒ ์ด์ค ์ธ์ ์ ์์ฑํ๊ณ ์์ ์ด ๋๋ ํ์ ์ธ์ ์ ์ข ๋ฃํ ์ ์์ต๋๋ค. | ||
|
||
์๋ต์ ์์ฑํ๊ธฐ ์ ์๋ `yield`๋ฅผ ํฌํจํ์ฌ ๊ทธ ์ด์ ์ ์ฝ๋๋ง์ด ์คํ๋ฉ๋๋ค: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At line 38, "yield statement" is translated as "yield ๋ฌธ", but at line 30, it is translated simply as "yield". It would be more appropriate to consistently use "yield ๋ฌธ" in both cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timothy-jeong Thanks for the feedback! I have applied the suggested changes. ๐
|
||
## `yield`๋ฅผ ์ฌ์ฉํ๋ ํ์ ์์กด์ฑ | ||
|
||
์ด๋ค ํฌ๊ธฐ์ ํํ์ ํ์ ์์กด์ฑ๊ณผ ํ์ ์์กด์ฑ์ "ํธ๋ฆฌ"๋ ๊ฐ์ง ์ ์์ผ๋ฉฐ, ์ด๋ค ๋ชจ๋๊ฐ `yield`๋ฅผ ์ฌ์ฉํ ์ ์์ต๋๋ค. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n the sentence "You can have sub-dependencies and 'trees' of sub-dependencies of any size and shape, and any or all of them can use yield," rather than explicitly translating "any" as "์ด๋ค," it would be more natural to translate it as "๋ชจ๋ " (all).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timothy-jeong Thanks for the feedback! I have applied the suggested changes. ๐
๐ Docs preview for commit 488e38d at: https://f9de835e.fastapitiangolo.pages.dev Modified Pages |
๐ Docs preview for commit c2be59d at: https://756b6e94.fastapitiangolo.pages.dev Modified Pages |
๐ Docs preview for commit 4a5c436 at: https://7d27f3b6.fastapitiangolo.pages.dev Modified Pages |
๐ Docs preview for commit 67cb71e at: https://06db60bb.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have addressed all the requested changes. Thanks for the review! ๐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!
Thanks for your work! @11kkw ๐
|
๋ด์ฉ
์ด PR์
docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
ํ์ผ์ ๋ํ ํ๊ตญ์ด ๋ฒ์ญ์ ์ถ๊ฐํฉ๋๋ค. FastAPI ํ๋ก์ ํธ์ ์ฒ์์ผ๋ก ๊ธฐ์ฌํ๋ PR์ด๋ฉฐ, ๊ณต์ ๋ฌธ์๋ฅผ ๊ธฐ๋ฐ์ผ๋ก ๋ฒ์ญ์ ์๋ฃํ์ต๋๋ค.์ฐธ๊ณ ์ฌํญ
docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
ย #4087)์ด ๊ฐ์ ํ์ผ์ ๋ฒ์ญํ๋ ์์ ์ผ๋ก ๋ณด์ ๋๋ค. ๊ทธ๋ฌ๋ ํด๋น PR์ 2022๋ 7์ 4์ผ์ ๋ซํ๊ณ , ์ดํ ๋ณํฉ๋์ง ์์์ต๋๋ค.๋ฒ์ญ ๊ธฐ์ค
์์ ์ด๋ ฅ
๐ Add Korean translation for docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
์ฒ์ ๊ธฐ์ฌ์ ๋ํ ๋ฉ์์ง
๊ฒํ ์์ฒญ
docs/ko/docs/tutorial/dependencies/dependencies-with-yield.md
ย #4087)๊ณผ ์ค๋ณต ์์ ์ธ์ง, ์๋๋ฉด ๊ธฐ์กด ์์ ์์ ๊ฐ์ ์ด ํ์ํ ๋ถ๋ถ์ด ์์ด์ผ ๋ณํฉ๋์ง ์์๋์ง์ ๋ํ ์๊ฒฌ๋ ๋ถํ๋๋ฆฝ๋๋ค.PR์ ๋ํ ํผ๋๋ฐฑ๊ณผ ์กฐ์ธ์ ์ ๊ทน์ ์ผ๋ก ๋ฐ์ํ๊ฒ ์ต๋๋ค. ์๋ก์ด ๊ธฐ์ฌ์๋ฅผ ์ํ ๋์์ ์ฃผ์ ์ ๊ฐ์ฌํฉ๋๋ค!