⬆️ Update anyio version in test suite #13128
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Jan 1, 2025
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
graingert
commented
Jan 5, 2025
|
@tiangolo hmm python 3.8 is no longer supported, and no longer supported by starlette. What would you like me to do:
|
|
Hi @graingert! In general, we do try to keep support for older Python versions, even when they're EOL, as long as it doesn't become too burdensome on our end (e.g. issues with CI, etc). In this case, I do think we'll want to continue support for Python 3.8 at least for a bit longer. As such, only bumping for 3.9+ would make the most sense to me. |
|
Just as a maintenance note: I'll put this PR in draft as long as the test suite is failing. Feel free to mark it as "Ready for review" once you're done and everything is green! 🙏 |
|
This pull request has a merge conflict that needs to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.