SVG Favicon #19
Merged
SVG Favicon #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for xeoxeo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I think I figured it out! Made the same mistake I did previously with custom fonts where I made the changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
favicon theme inheritance
So I merged PR #18 on Xeo https://github.com/famebot/xeo/pull/18/files and released 6.1.0 with those changes, now up on https://xeo.land
Now in Xogo, I want to use a favicon.svg but instead Lume is pulling in Simple Blog’s favicon.png and not including the favicon.svg from the root directory in the build.
Where did I go wrong?FIXED see belowmod.tsagain? Is it time to give up on this child theme dream of mine??