new(pkg,tests): support Falco running with container plugin. #69
Conversation
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
|
/hold |
| @@ -67,21 +67,6 @@ func NewFalcoctlExecutableRunner(t *testing.T) run.Runner { | |||
| return runner | |||
| } | |||
|
|
|||
| // IsRootUser returns true if the program is run as root. | |||
| @@ -42,6 +41,7 @@ func init() { | |||
| flag.StringVar(&falcoBinary, "falco-binary", falcoBinary, "Falco executable binary path") | |||
| flag.StringVar(&falcoctlBinary, "falcoctl-binary", falcoctlBinary, "falcoctl executable binary path") | |||
| flag.StringVar(&falco.FalcoConfig, "falco-config", falco.FalcoConfig, "Falco config file path") | |||
| flag.StringVar(&falco.FalcoContainerPluginLibrary, "falco-container-plugin", falco.FalcoContainerPluginLibrary, "Path to the Falco container plugin shared object.") | |||
There was a problem hiding this comment.
I thought it could be helpful being able to run the testing framework pointing to a local libcontainer.so, to eventually test container plugin changes against the testing framework.
By default, it expects to find the shared object under /usr/share/falco/plugins/libcontainer.so.
| // If we are running a newer Falco version with | ||
| // the container plugin, enforce it to the | ||
| if _, err := os.Stat(FalcoContainerPluginLibrary); err == nil { | ||
| plugins = append(plugins, &PluginConfigInfo{ |
There was a problem hiding this comment.
If the container plugin is present, append it when generating the plugin config.
|
falcosecurity/falco#3482 test-dev-packages-arm64 is now down to only 6 failures! And this PR passes tests against latest dev Falco thus:
Remaining failures are most probably due to other issues that will try to track after this one. |
|
/cc @leogr |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.