Skip to content

update(cmake): bumped container plugin to 0.2.2. #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

update(cmake): bumped container plugin to 0.2.2. #2394

merged 1 commit into from
May 7, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 6, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
update(cmake): bumped container plugin to 0.2.2.
696e54c 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone May 6, 2025
@poiana poiana added the size/XS label May 6, 2025
@poiana
Copy link
Contributor

poiana commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from hbrueckner and Molter73 May 6, 2025 15:39
@poiana poiana added the approved label May 6, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/milestone 0.21.0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025

Perf diff from master - unit tests

    34.40%     +0.49%  [.] sinsp_thread_manager::create_thread_dependencies
     1.80%     -0.31%  [.] sinsp_thread_manager::get_thread_ref
     7.32%     -0.31%  [.] sinsp::next
     1.51%     +0.29%  [.] user_group_updater::~user_group_updater
     3.61%     +0.21%  [.] next_event_from_file
     0.24%     +0.14%  [.] scap_event_has_large_payload
     0.26%     -0.14%  [.] scap_get_event_info_table
     0.62%     -0.13%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     1.17%     -0.13%  [.] sinsp::fetch_next_event
     1.65%     +0.12%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0148         +0.0148           148           151           148           151
BM_sinsp_split_median                                          +0.0137         +0.0138           149           151           149           151
BM_sinsp_split_stddev                                          -0.1438         -0.1453             1             1             1             1
BM_sinsp_split_cv                                              -0.1562         -0.1578             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0339         +0.0340            57            59            57            59
BM_sinsp_concatenate_paths_relative_path_median                +0.0354         +0.0355            57            59            57            59
BM_sinsp_concatenate_paths_relative_path_stddev                +4.2710         +4.2684             0             2             0             2
BM_sinsp_concatenate_paths_relative_path_cv                    +4.0980         +4.0950             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0084         +0.0085            23            24            23            24
BM_sinsp_concatenate_paths_empty_path_median                   +0.0088         +0.0089            23            24            23            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4533         -0.4541             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4578         -0.4588             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.2259         +0.2261            54            66            54            66
BM_sinsp_concatenate_paths_absolute_path_median                +0.2354         +0.2355            53            66            53            66
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.0872         +0.0873             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.1132         -0.1132             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (bca865f) to head (696e54c).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2394   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         231      231           
  Lines       30361    30361           
  Branches     4658     4658           
=======================================
  Hits        23434    23434           
  Misses       6927     6927
Flag Coverage Δ
libsinsp 77.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedeDP FedeDP mentioned this pull request May 7, 2025
Merged
@poiana poiana added the lgtm label May 7, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap May 7, 2025
@poiana poiana merged commit 5afe6d2 into master May 7, 2025
47 checks passed
@poiana poiana deleted the update/container_022 branch May 7, 2025 08:58
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap May 7, 2025
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@leogr leogr

@LucaGuerra LucaGuerra

Labels
approved area/build dco-signoff: yes kind/cleanup lgtm release-note-none size/XS
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @leogr @LucaGuerra