Skip to content

feat(userspace/libsinsp)!: drop syslog support #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

feat(userspace/libsinsp)!: drop syslog support #2393

merged 1 commit into from
May 7, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented May 6, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR drops the syslog support by removing both the corresponding builtin field extraction and parsing capabilities. syslog support is currently (to the extent of our knowledge) unused, and removing it helps in maintaining the codebase cleaner and more maintanable.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: drop `syslog` support

@poiana poiana requested review from hbrueckner and Molter73 May 6, 2025 13:48
@poiana poiana added the size/XL label May 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

Perf diff from master - unit tests

     4.13%     -0.62%  [.] sinsp_thread_manager::find_thread
     1.60%     +0.46%  [.] sinsp_parser::process_event
     1.46%     -0.41%  [.] user_group_updater::~user_group_updater
    34.38%     -0.37%  [.] sinsp_thread_manager::create_thread_dependencies
     1.34%     -0.21%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     5.46%     -0.21%  [.] sinsp_evt::get_type
     0.86%     +0.20%  [.] sinsp_evt::get_ts
     2.21%     -0.20%  [.] sinsp_thread_manager::get_thread_ref
     0.78%     +0.18%  [.] sinsp::fetch_next_event
     1.11%     +0.17%  [.] next

Heap diff from master - unit tests

peak heap memory consumption: 1.02K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 1.02K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.1842         +0.1842           148           175           148           175
BM_sinsp_split_median                                          +0.1858         +0.1858           148           175           148           175
BM_sinsp_split_stddev                                          +0.4363         +0.4346             1             1             1             1
BM_sinsp_split_cv                                              +0.2129         +0.2115             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1727         +0.1727            56            66            56            66
BM_sinsp_concatenate_paths_relative_path_median                +0.2021         +0.2021            55            66            55            66
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7726         -0.7729             3             1             3             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8061         -0.8063             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0552         +0.0552            23            25            23            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0544         +0.0544            23            25            23            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +3.0032         +3.0064             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +2.7937         +2.7968             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0221         -0.0221            64            63            64            63
BM_sinsp_concatenate_paths_absolute_path_median                -0.0283         -0.0283            64            62            64            62
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.3323         +0.3330             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.3624         +0.3632             0             0             0             0

ekoops
ekoops commented May 6, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (59a68aa) to head (52ba19a).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
+ Coverage   77.18%   77.25%   +0.07%     
==========================================
  Files         231      227       -4     
  Lines       30357    30290      -67     
  Branches     4658     4638      -20     
==========================================
- Hits        23430    23402      -28     
+ Misses       6927     6888      -39
Flag Coverage Δ
libsinsp 77.25% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
feat(userspace/libsinsp)!: drop syslog support
52ba19a 
BREAKING CHANGE: drop `syslog` support,
`sinsp_parser::get_syslog_decoder()`, `sinsp_filter_check_syslog`
component and `sinsp_syslog_decoder` component

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/drop-syslog branch from a8ab80f to 52ba19a Compare May 7, 2025 09:25
@ekoops ekoops requested a review from FedeDP May 7, 2025 09:25
FedeDP
FedeDP approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label May 7, 2025
@poiana
Copy link
Contributor

poiana commented May 7, 2025

LGTM label has been added.

Git tree hash: fa8c72c2aad01ec959c54ef6dcdda9742cf4abe9

@poiana poiana added the approved label May 7, 2025
@FedeDP
Copy link
Contributor

FedeDP commented May 7, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone May 7, 2025
incertum
incertum approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap May 7, 2025
@poiana
Copy link
Contributor

poiana commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 729ead2 into falcosecurity:master May 7, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap May 7, 2025
@ekoops ekoops deleted the ekoops/drop-syslog branch May 9, 2025 07:28
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
@leogr leogr mentioned this pull request May 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

+1 more reviewer

@incertum incertum incertum approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@FedeDP FedeDP

@incertum incertum

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/XL
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ekoops @poiana @FedeDP @Molter73 @incertum