Skip to content

fix(ci): download custom container plugin from workflow. #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

fix(ci): download custom container plugin from workflow. #2390

merged 2 commits into from
May 6, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 6, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Since we cannot have multi-steps action when invoking a reusable workflow, download the container plugin artifact upon override instead of moving: we don't expect to receive a path but an artifact name now.
This means that the container plugin CI will become:

  libs-tests:
    needs: [build-linux]
    uses: falcosecurity/libs/.github/workflows/reusable_e2e_tests.yaml@master
    with:
      container_plugin_artifact_name: libcontainer-amd64

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
fix(ci): download custom container plugin from workflow.
13688f0 
Since we cannot have multi-steps action when invoking a reusable workflow.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/cc @Molter73 @LucaGuerra

@poiana poiana requested review from LucaGuerra and Molter73 May 6, 2025 10:25
@poiana poiana added the size/S label May 6, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone May 6, 2025
@poiana
Copy link
Contributor

poiana commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested a review from hbrueckner May 6, 2025 10:25
@poiana poiana added the approved label May 6, 2025
@FedeDP FedeDP mentioned this pull request May 6, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (b1b30d3) to head (b5dad5a).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2390   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         231      231           
  Lines       30357    30357           
  Branches     4658     4658           
=======================================
  Hits        23430    23430           
  Misses       6927     6927
Flag Coverage Δ
libsinsp 77.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/close

@poiana poiana closed this May 6, 2025
@poiana
Copy link
Contributor

poiana commented May 6, 2025

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in Falco Roadmap May 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

Perf diff from master - unit tests

     6.65%     +1.93%  [.] sinsp::next
     3.31%     +1.72%  [.] next_event_from_file
    34.69%     -1.34%  [.] sinsp_thread_manager::create_thread_dependencies
     1.07%     -0.65%  [.] sinsp_fdtable::find
     1.52%     +0.64%  [.] next
     1.97%     -0.61%  [.] user_group_updater::~user_group_updater
     6.38%     -0.43%  [.] sinsp_parser::reset
     5.32%     -0.28%  [.] sinsp_evt::get_type
     0.78%     +0.27%  [.] sinsp::fetch_next_event
     2.28%     +0.26%  [.] gzfile_read

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0019         -0.0020           149           149           149           149
BM_sinsp_split_median                                          -0.0029         -0.0029           149           149           149           149
BM_sinsp_split_stddev                                          -0.4882         -0.4845             1             0             1             0
BM_sinsp_split_cv                                              -0.4873         -0.4835             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0589         +0.0589            57            60            57            60
BM_sinsp_concatenate_paths_relative_path_median                +0.0574         +0.0574            57            60            57            60
BM_sinsp_concatenate_paths_relative_path_stddev                +0.3136         +0.3141             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.2406         +0.2410             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0503         -0.0503            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0478         -0.0478            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7179         -0.7174             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7029         -0.7024             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0493         +0.0493            58            61            58            61
BM_sinsp_concatenate_paths_absolute_path_median                +0.0584         +0.0584            58            61            58            61
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.7542         -0.7542             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.7657         -0.7658             0             0             0             0

@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/reopen

@poiana poiana reopened this May 6, 2025
@github-project-automation github-project-automation bot moved this from Done to In progress in Falco Roadmap May 6, 2025
@poiana
Copy link
Contributor

poiana commented May 6, 2025

@FedeDP: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@FedeDP FedeDP force-pushed the chore/download_build_lib branch from 94e963c to c217e35 Compare May 6, 2025 12:15
@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

Working CI for container plugin: https://github.com/falcosecurity/plugins/actions/runs/14859319712/job/41720159726?pr=759

@poiana poiana added size/M and removed size/S labels May 6, 2025
@FedeDP FedeDP force-pushed the chore/download_build_lib branch from 967e7e1 to 0ce4f66 Compare May 6, 2025 12:27
@FedeDP
chore(ci): add libsrepo and libsversion inputs to reusable_e2e_tests …
b5dad5a 
…workflow.

Also, drop concurrency key.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the chore/download_build_lib branch from 0ce4f66 to b5dad5a Compare May 6, 2025 12:38
@poiana poiana added the lgtm label May 6, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented May 6, 2025

/unhold

@poiana poiana merged commit 9ffd335 into master May 6, 2025
47 checks passed
@poiana poiana deleted the chore/download_build_lib branch May 6, 2025 13:04
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap May 6, 2025
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@Molter73 Molter73 Awaiting requested review from Molter73

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@LucaGuerra LucaGuerra

Labels
approved area/CI dco-signoff: yes kind/cleanup lgtm release-note-none size/M
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @leogr @LucaGuerra