Skip to content

update(cmake): updated container plugin to 0.2.1. #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

update(cmake): updated container plugin to 0.2.1. #2379

merged 1 commit into from
Apr 29, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 29, 2025

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
update(cmake): updated container plugin to 0.2.1.
55203ad 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from hbrueckner and incertum April 29, 2025 10:45
@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 29, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 29, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     5.96%     +0.58%  [.] sinsp::next
     6.69%     -0.38%  [.] sinsp_parser::reset
     2.49%     -0.36%  [.] sinsp_evt::load_params
     5.16%     +0.22%  [.] sinsp_evt::get_type
     2.53%     +0.21%  [.] gzfile_read
     0.95%     -0.20%  [.] libsinsp::sinsp_suppress::process_event
     0.32%     +0.19%  [.] sinsp_parser::parse_context_switch
     0.47%     -0.16%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     0.96%     -0.15%  [.] sinsp_evt_filter::sinsp_evt_filter
     0.67%     +0.13%  [.] sinsp_parser::event_cleanup

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0002         +0.0002           150           150           150           150
BM_sinsp_split_median                                          +0.0025         +0.0025           149           150           149           150
BM_sinsp_split_stddev                                          -0.7298         -0.7294             2             0             2             0
BM_sinsp_split_cv                                              -0.7299         -0.7294             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0182         +0.0182            59            60            59            60
BM_sinsp_concatenate_paths_relative_path_median                +0.0172         +0.0172            59            60            59            60
BM_sinsp_concatenate_paths_relative_path_stddev                -0.6071         -0.6070             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6141         -0.6140             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0045         -0.0045            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   +0.0031         +0.0031            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8987         -0.8986             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8982         -0.8981             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0474         +0.0474            63            66            63            66
BM_sinsp_concatenate_paths_absolute_path_median                +0.0643         +0.0643            62            66            62            66
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.8112         -0.8111             2             0             2             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.8197         -0.8196             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (ca91cb1) to head (55203ad).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2379   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files         229      229           
  Lines       30316    30316           
  Branches     4657     4655    -2     
=======================================
  Hits        23352    23352           
  Misses       6964     6964
Flag Coverage Δ
libsinsp 77.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poiana poiana added the lgtm label Apr 29, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 29, 2025
@poiana poiana merged commit beea29f into master Apr 29, 2025
64 of 66 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 29, 2025
@poiana poiana deleted the update/container_plugin_021 branch April 29, 2025 14:47
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@leogr leogr leogr approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@incertum incertum Awaiting requested review from incertum

Assignees

@gnosek gnosek

@leogr leogr

Labels
approved area/build dco-signoff: yes kind/cleanup lgtm release-note-none size/XS
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @gnosek @leogr