Skip to content

feat(userspace/libsinsp): use factory in evt proc's build_fdinfo() #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

feat(userspace/libsinsp): use factory in evt proc's build_fdinfo() #2373

merged 1 commit into from
Apr 24, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 24, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR allows event_processor::build_fdinfo() to use fdinfo factory. In order to avoid call loops, it extracts the fdinfo creation logic in a separate private fdinfo factory's method, and provides access to it via the attorney-client idiom.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ekoops
feat(userspace/libsinsp): use factory in evt proc's build_fdinfo()
62bb296 
Use fdinfo factory in `event_processor::build_fdinfo()`. In order to
avoid call loops, extract the fdinfo creation logic in a separate
private fdinfo factory method and provide access to it via the
attorney-client idiom.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana requested a review from hbrueckner April 24, 2025 09:53
@poiana poiana requested a review from mstemm April 24, 2025 09:53
@poiana poiana added the size/S label Apr 24, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     6.33%     +0.46%  [.] sinsp::next
     4.18%     -0.41%  [.] next_event_from_file
     5.35%     +0.40%  [.] sinsp_parser::reset
     5.87%     -0.40%  [.] sinsp_evt::get_type
     2.23%     +0.38%  [.] gzfile_read
    35.13%     +0.29%  [.] sinsp_thread_manager::create_thread_dependencies
     0.44%     +0.20%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     1.70%     +0.18%  [.] sinsp_thread_manager::get_thread_ref
     0.51%     -0.18%  [.] scap_next
     0.36%     -0.16%  [.] 0x0000000000071e90

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0082         -0.0082           150           148           150           148
BM_sinsp_split_median                                          -0.0093         -0.0093           150           148           150           148
BM_sinsp_split_stddev                                          +0.6302         +0.6282             1             1             1             1
BM_sinsp_split_cv                                              +0.6437         +0.6416             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1293         -0.1293            65            57            65            57
BM_sinsp_concatenate_paths_relative_path_median                -0.1259         -0.1259            65            57            65            57
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5489         -0.5483             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.4819         -0.4813             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0045         -0.0044            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0059         -0.0059            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.2482         +1.2583             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +1.2582         +1.2683             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1108         -0.1108            61            55            61            55
BM_sinsp_concatenate_paths_absolute_path_median                -0.1110         -0.1110            61            54            61            54
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.2029         -0.2028             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.1036         -0.1035             0             0             0             0

@FedeDP
Copy link
Contributor

FedeDP commented Apr 24, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 24, 2025
FedeDP
FedeDP approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 24, 2025
@poiana
Copy link
Contributor

poiana commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 24, 2025

LGTM label has been added.

Git tree hash: 2bb0472fdba6b0008a277242884a033113c8e887

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (9f139a0) to head (62bb296).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2373   +/-   ##
=======================================
  Coverage   77.02%   77.03%           
=======================================
  Files         229      229           
  Lines       30336    30341    +5     
  Branches     4657     4657           
=======================================
+ Hits        23367    23372    +5     
  Misses       6969     6969
Flag Coverage Δ
libsinsp 77.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 24, 2025
@poiana poiana merged commit ca91cb1 into falcosecurity:master Apr 24, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 24, 2025
@ekoops ekoops deleted the ekoops/fdinfo-attorney branch April 24, 2025 10:40
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@FedeDP FedeDP

@LucaGuerra LucaGuerra

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note-none size/S
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @FedeDP @poiana @LucaGuerra