Skip to content

feat(userspace/libsinsp)!: remove unused sinsp public APIs #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

feat(userspace/libsinsp)!: remove unused sinsp public APIs #2369

merged 1 commit into from
Apr 23, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 23, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR removes unused sinsp::set_tid_to_remove(), sinsp::set_tid_of_fd_to_remove(), sinsp::get_tid_of_fd_to_remove() and two sinsp::get_fds_to_remove() variants APIs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: remove unused `sinsp` public APIs

@poiana poiana added dco-signoff: yes kind/feature New feature or request labels Apr 23, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2025 •
edited
Loading

Perf diff from master - unit tests

     5.92%     -0.56%  [.] sinsp_evt::get_type
     2.08%     +0.39%  [.] sinsp_evt::load_params
     4.07%     +0.38%  [.] sinsp_thread_manager::find_thread
     6.23%     +0.34%  [.] sinsp::next
     3.47%     +0.26%  [.] next_event_from_file
     0.69%     -0.21%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     6.16%     -0.21%  [.] sinsp_parser::reset
     2.50%     -0.16%  [.] gzfile_read
     1.80%     -0.16%  [.] sinsp_parser::process_event
     0.03%     +0.14%  [.] scap_get_event_info_table

Heap diff from master - unit tests

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0073         -0.0073           149           148           149           148
BM_sinsp_split_median                                          -0.0075         -0.0074           149           148           149           148
BM_sinsp_split_stddev                                          +0.0174         +0.0165             1             1             1             1
BM_sinsp_split_cv                                              +0.0249         +0.0239             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0346         +0.0346            56            58            56            58
BM_sinsp_concatenate_paths_relative_path_median                +0.0350         +0.0350            56            58            56            58
BM_sinsp_concatenate_paths_relative_path_stddev                +0.0524         +0.0537             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0172         +0.0185             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0378         -0.0378            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0364         -0.0364            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7316         -0.7310             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7210         -0.7205             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1563         +0.1563            57            66            57            66
BM_sinsp_concatenate_paths_absolute_path_median                +0.1554         +0.1554            57            66            57            66
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.7237         +0.7242             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.4908         +0.4912             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.01%. Comparing base (997bf75) to head (3f080ff).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2369   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files         229      229           
  Lines       30329    30329           
  Branches     4657     4657           
=======================================
  Hits        23359    23359           
  Misses       6970     6970
Flag Coverage Δ
libsinsp 77.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP
FedeDP previously approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 23, 2025
@poiana
Copy link
Contributor

poiana commented Apr 23, 2025

LGTM label has been added.

Git tree hash: a4859f5f14dcbe70d903fd33e7527897cfcd3c8d

@FedeDP
Copy link
Contributor

FedeDP commented Apr 23, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 23, 2025
@ekoops ekoops changed the title feat(userspace/libsinsp)!: remove unused sinsp public APIs wip: feat(userspace/libsinsp)!: remove unused sinsp public APIs Apr 23, 2025
@ekoops
feat(userspace/libsinsp)!: remove unused sinsp public APIs
3f080ff 
BREAKING CHANGE: remove `sinsp::set_tid_to_remove()`,
`sinsp::set_tid_of_fd_to_remove()`, `sinsp::get_tid_of_fd_to_remove()`
and two `sinsp::get_fds_to_remove()` variants APIs

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/remove-api branch from 7042565 to 3f080ff Compare April 23, 2025 10:53
@poiana poiana removed the lgtm label Apr 23, 2025
@poiana poiana requested a review from FedeDP April 23, 2025 10:53
@poiana poiana added size/S and removed size/XS labels Apr 23, 2025
@ekoops ekoops changed the title wip: feat(userspace/libsinsp)!: remove unused sinsp public APIs feat(userspace/libsinsp)!: remove unused sinsp public APIs Apr 23, 2025
FedeDP
FedeDP approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 23, 2025
@poiana
Copy link
Contributor

poiana commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 23, 2025

LGTM label has been added.

Git tree hash: c3282be1523384959d5dba0ea99e558881dd37fa

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 23, 2025
@poiana poiana merged commit 2294a56 into falcosecurity:master Apr 23, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 23, 2025
@ekoops ekoops deleted the ekoops/remove-api branch April 23, 2025 16:30
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@Andreagit97 Andreagit97 Awaiting requested review from Andreagit97

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@FedeDP FedeDP

@LucaGuerra LucaGuerra

Labels
approved area/libsinsp dco-signoff: yes kind/design kind/feature New feature or request lgtm release-note size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @LucaGuerra