Skip to content

feat(userspace/libsinsp)!: use timestamper in thread mgr #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

feat(userspace/libsinsp)!: use timestamper in thread mgr #2366

merged 1 commit into from
Apr 23, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 23, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It replaces sinsp::get_lastevent_ts() accesses in sinsp_thread_manager with timestamper::get_cached_ts() accesses.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: use `timestamper` in thread mgr

@poiana poiana requested review from FedeDP and hbrueckner April 23, 2025 08:53
@ekoops ekoops mentioned this pull request Apr 23, 2025
Open
25 tasks
@ekoops
feat(userspace/libsinsp)!: use timestamper in thread mgr
d42983d 
Replace `sinsp::get_lastevent_ts()` accesses in
`sinsp_thread_manager` with `timestamper::get_cached_ts()`
accesses.

BREAKING CHANGE: update `sinsp_thread_manager` constructor

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/isolate-ts-thread-mgr branch from e17c2b4 to d42983d Compare April 23, 2025 09:08
FedeDP
FedeDP approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 23, 2025
@poiana
Copy link
Contributor

poiana commented Apr 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 23, 2025

LGTM label has been added.

Git tree hash: b527641ca16ec0cab3d83649a79448e509a32e1c

@FedeDP
Copy link
Contributor

FedeDP commented Apr 23, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 23, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (997bf75) to head (d42983d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/sinsp.cpp 94.44% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2366   +/-   ##
=======================================
  Coverage   77.01%   77.02%           
=======================================
  Files         229      229           
  Lines       30329    30332    +3     
  Branches     4657     4657           
=======================================
+ Hits        23359    23363    +4     
+ Misses       6970     6969    -1
Flag Coverage Δ
libsinsp 77.02% <95.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     6.16%     -0.74%  [.] sinsp_parser::reset
     6.23%     +0.65%  [.] sinsp::next
    35.79%     -0.65%  [.] sinsp_thread_manager::create_thread_dependencies
     2.08%     +0.40%  [.] sinsp_evt::load_params
     1.80%     +0.33%  [.] sinsp_parser::process_event
     5.92%     +0.30%  [.] sinsp_evt::get_type
     2.11%     -0.28%  [.] sinsp_thread_manager::get_thread_ref
     1.25%     -0.22%  [.] next
     0.69%     -0.20%  [.] std::_Hashtable<conversion_key, std::pair<conversion_key const, conversion_info>, std::allocator<std::pair<conversion_key const, conversion_info> >, std::__detail::_Select1st, std::equal_to<conversion_key>, std::hash<conversion_key>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     0.88%     +0.19%  [.] sinsp_evt_filter::sinsp_evt_filter

Heap diff from master - unit tests

peak heap memory consumption: -16B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0069         +0.0069           149           150           149           150
BM_sinsp_split_median                                          +0.0078         +0.0078           149           150           149           150
BM_sinsp_split_stddev                                          -0.4944         -0.4958             1             1             1             1
BM_sinsp_split_cv                                              -0.4979         -0.4993             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1142         +0.1142            56            62            56            62
BM_sinsp_concatenate_paths_relative_path_median                +0.1184         +0.1185            56            62            56            62
BM_sinsp_concatenate_paths_relative_path_stddev                +2.0871         +2.0874             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.7707         +1.7709             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0125         -0.0125            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0120         -0.0120            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4062         -0.4063             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.3987         -0.3988             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1396         +0.1396            57            65            57            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.1419         +0.1419            57            65            57            65
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.3623         +0.3631             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.1955         +0.1961             0             0             0             0

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 23, 2025
@poiana poiana merged commit 7060dfb into falcosecurity:master Apr 23, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 23, 2025
@ekoops ekoops deleted the ekoops/isolate-ts-thread-mgr branch April 23, 2025 16:31
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@FedeDP FedeDP

@LucaGuerra LucaGuerra

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/M
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @LucaGuerra