Skip to content

feat(userspace/libsinsp)!: remove unused m_ts from erase_fd_params #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

feat(userspace/libsinsp)!: remove unused m_ts from erase_fd_params #2361

merged 1 commit into from
Apr 22, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 18, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It removes the unused m_ts field from the erase_fd_params struct. Indeed, this field is set but never accessed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: remove unused `m_ts` from `erase_fd_params`

@ekoops
feat(userspace/libsinsp)!: remove unused m_ts from erase_fd_params
6375d12 
BREAKING CHANGE: remove `m_ts` field form `erase_fd_params`

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana added dco-signoff: yes kind/feature New feature or request labels Apr 18, 2025
@poiana poiana requested review from hbrueckner and Molter73 April 18, 2025 11:04
@ekoops ekoops mentioned this pull request Apr 18, 2025
Open
25 tasks
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

    34.95%     +0.49%  [.] sinsp_thread_manager::create_thread_dependencies
     0.69%     -0.31%  [.] sinsp_evt::get_direction
     6.27%     -0.31%  [.] sinsp::next
     0.57%     +0.26%  [.] libsinsp::events::is_unknown_event
     1.61%     +0.21%  [.] sinsp_parser::process_event
     1.71%     +0.21%  [.] sinsp_thread_manager::get_thread_ref
     1.22%     -0.20%  [.] user_group_updater::user_group_updater
     0.27%     +0.18%  [.] sinsp_evt::is_filtered_out
     0.86%     -0.17%  [.] sinsp_parser::event_cleanup
     0.20%     +0.16%  [.] 0x0000000000071e90

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0238         -0.0238           152           148           152           148
BM_sinsp_split_median                                          -0.0237         -0.0237           152           148           152           148
BM_sinsp_split_stddev                                          -0.3641         -0.3636             1             1             1             1
BM_sinsp_split_cv                                              -0.3485         -0.3481             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0379         -0.0379            64            61            64            61
BM_sinsp_concatenate_paths_relative_path_median                -0.0375         -0.0375            64            61            64            61
BM_sinsp_concatenate_paths_relative_path_stddev                +0.0691         +0.0666             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.1113         +0.1086             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0494         -0.0494            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0458         -0.0458            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7525         -0.7525             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7396         -0.7397             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1011         +0.1011            61            68            61            68
BM_sinsp_concatenate_paths_absolute_path_median                +0.1003         +0.1003            61            67            61            67
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.1156         +0.1156             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.0132         +0.0132             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (24539f5) to head (6375d12).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2361   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files         228      228           
  Lines       30324    30320    -4     
  Branches     4654     4654           
=======================================
- Hits        23363    23360    -3     
+ Misses       6961     6960    -1
Flag Coverage Δ
libsinsp 77.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP
FedeDP approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 22, 2025
@poiana
Copy link
Contributor

poiana commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 22, 2025

LGTM label has been added.

Git tree hash: c20940c44f13f431438b2f640c00053002d7ce08

@FedeDP
Copy link
Contributor

FedeDP commented Apr 22, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 22, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 22, 2025
@poiana poiana merged commit 378b322 into falcosecurity:master Apr 22, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 22, 2025
@ekoops ekoops deleted the ekoops/remove-ts branch April 22, 2025 09:28
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@gnosek gnosek

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/XS
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @gnosek