Skip to content

feat(userspace/libsinsp)!: remove dependency on parser from thread mgr #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

feat(userspace/libsinsp)!: remove dependency on parser from thread mgr #2359

merged 1 commit into from
Apr 22, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 18, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It removes the dependency on parser from sinsp_thread_manager::remove_main_thread_fdtable() and introduces a direct dependency on the observer.
Moreover, it makes sinsp_thread_manager::remove_main_thread_fdtable() private and const, and update the sinsp_thread_manager constructor.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: remove dependency on parser from thread mgr

@ekoops ekoops mentioned this pull request Apr 18, 2025
Open
25 tasks
@poiana poiana added the size/M label Apr 18, 2025
@ekoops ekoops force-pushed the ekoops/remove-parser-thread-mgr branch from d316b19 to ce777bc Compare April 18, 2025 10:22
@ekoops
feat(userspace/libsinsp)!: remove dependency on parser from thread mgr
235529e 
BREAKING CHANGE: make
`sinsp_thread_manager::remove_main_thread_fdtable()` private and
const, and update `sinsp_thread_manager` constructor

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/remove-parser-thread-mgr branch from ce777bc to 235529e Compare April 18, 2025 10:25
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     3.62%     +2.14%  [.] next_event_from_file
    34.89%     -1.37%  [.] sinsp_thread_manager::create_thread_dependencies
     6.14%     +0.56%  [.] sinsp_parser::reset
     1.71%     +0.40%  [.] sinsp_thread_manager::get_thread_ref
     5.38%     -0.38%  [.] sinsp_evt::get_type
     1.22%     -0.37%  [.] user_group_updater::user_group_updater
     1.47%     -0.32%  [.] user_group_updater::~user_group_updater
     0.97%     -0.29%  [.] sinsp_evt::get_ts
     1.16%     +0.26%  [.] next
     2.59%     -0.25%  [.] gzfile_read

Heap diff from master - unit tests

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0188         -0.0188           152           149           152           149
BM_sinsp_split_median                                          -0.0204         -0.0204           152           149           152           149
BM_sinsp_split_stddev                                          -0.1496         -0.1491             1             1             1             1
BM_sinsp_split_cv                                              -0.1333         -0.1328             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0417         -0.0417            64            61            64            61
BM_sinsp_concatenate_paths_relative_path_median                -0.0465         -0.0465            64            61            64            61
BM_sinsp_concatenate_paths_relative_path_stddev                +2.6372         +2.6317             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +2.7956         +2.7898             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0185         -0.0185            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0166         -0.0166            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4552         -0.4557             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4449         -0.4455             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0585         +0.0585            61            65            61            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.0607         +0.0607            61            65            61            65
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3715         -0.3710             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4062         -0.4058             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.00%. Comparing base (24539f5) to head (235529e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/thread_manager.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2359      +/-   ##
==========================================
- Coverage   77.04%   77.00%   -0.04%     
==========================================
  Files         228      228              
  Lines       30324    30326       +2     
  Branches     4654     4658       +4     
==========================================
- Hits        23363    23354       -9     
- Misses       6961     6972      +11
Flag Coverage Δ
libsinsp 77.00% <83.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poiana poiana added the lgtm label Apr 22, 2025
@poiana
Copy link
Contributor

poiana commented Apr 22, 2025

LGTM label has been added.

Git tree hash: 57f891fb31d808cad4b90391e08add4dd5244510

FedeDP
FedeDP approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 22, 2025
@FedeDP
Copy link
Contributor

FedeDP commented Apr 22, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 22, 2025
@poiana
Copy link
Contributor

poiana commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit de00a6b into falcosecurity:master Apr 22, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 22, 2025
@ekoops ekoops deleted the ekoops/remove-parser-thread-mgr branch April 22, 2025 09:29
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@FedeDP FedeDP FedeDP approved these changes

@Andreagit97 Andreagit97 Awaiting requested review from Andreagit97

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@gnosek gnosek

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/M
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @gnosek