Skip to content

feat(userspace/libsinsp)!: extract thread mgr accessors/tables logics #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

feat(userspace/libsinsp)!: extract thread mgr accessors/tables logics #2356

merged 1 commit into from
Apr 18, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 17, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It moves sinsp_thread_manager::load_foreign_fields_accessors() method logic in sinsp, and provides two new setters
sinsp_thread_manager::set_foreign_field_accessors() and sinsp_thread_manager::set_foreign_tables() to enable tables and accessors setting on thread manager from sinsp.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: extract thread mgr accessors/tables logics

@ekoops
feat(userspace/libsinsp)!: extract thread mgr accessors/tables logics
939e64b 
Move `sinsp_thread_manager::load_foreign_fields_accessors()` method
logic in sinsp, and provide two new setters
`sinsp_thread_manager::set_foreign_field_accessors()` and
`sinsp_thread_manager::set_foreign_tables()` to enable tables
and accessors setting on thread manager from sinsp.

BREAKING CHANGE: remove
`sinsp_thread_manager::load_foreign_fields_accessors()` method

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops mentioned this pull request Apr 17, 2025
Open
25 tasks
@poiana poiana added the size/M label Apr 17, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.04%. Comparing base (689c7bf) to head (939e64b).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/sinsp.cpp 87.50% 2 Missing ⚠️
userspace/libsinsp/thread_manager.h 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2356      +/-   ##
==========================================
+ Coverage   77.03%   77.04%   +0.01%     
==========================================
  Files         228      228              
  Lines       30266    30278      +12     
  Branches     4636     4640       +4     
==========================================
+ Hits        23315    23328      +13     
+ Misses       6951     6950       -1
Flag Coverage Δ
libsinsp 77.04% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

incertum
incertum approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the last PR re #2343.

Super useful, thanks!

/approve

@poiana poiana added the lgtm label Apr 18, 2025
@poiana
Copy link
Contributor

poiana commented Apr 18, 2025

LGTM label has been added.

Git tree hash: c6a8672f606929c3aa8c8ea618b789ce9da0232a

FedeDP
FedeDP approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 18, 2025
@poiana
Copy link
Contributor

poiana commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Apr 18, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 18, 2025
@poiana poiana merged commit 19adaa8 into falcosecurity:master Apr 18, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 18, 2025
@ekoops ekoops deleted the ekoops/foreign-setters branch April 18, 2025 08:24
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

+1 more reviewer

@incertum incertum incertum approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@FedeDP FedeDP

@incertum incertum

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/M
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @incertum