Skip to content

feat(userspace/libsinsp)!: move server ports accounting in thread mgr #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

feat(userspace/libsinsp)!: move server ports accounting in thread mgr #2351

merged 1 commit into from
Apr 15, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 15, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It moves bound server ports accounting from sinsp_threadinfo::add_fd_from_scap() method to a new sinsp_thread_manager::add_thread_fd_from_scap() API.
Notice that this changes the sinsp_threadinfo::add_fd_from_scap() method semantic.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: move server ports accounting in thread mgr

@ekoops
feat(userspace/libsinsp)!: move server ports accounting in thread mgr
4b21b72 
Move bound server ports accounting from
`sinsp_threadinfo::add_fd_from_scap()` to new
`sinsp_thread_manager::add_thread_fd_from_scap()` API.

BREAKING CHANGE: change sinsp_threadinfo::add_fd_from_scap() semantic

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana requested review from FedeDP and hbrueckner April 15, 2025 10:27
@ekoops ekoops mentioned this pull request Apr 15, 2025
Open
25 tasks
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

    36.61%     -0.43%  [.] sinsp_thread_manager::create_thread_dependencies
     1.52%     -0.36%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.97%     -0.33%  [.] sinsp_thread_manager::get_thread_ref
     5.52%     -0.32%  [.] sinsp_evt::get_type
     4.08%     +0.26%  [.] sinsp_thread_manager::find_thread
     1.05%     +0.26%  [.] next
     2.24%     +0.24%  [.] gzfile_read
     2.39%     +0.24%  [.] sinsp_evt::load_params
     1.02%     +0.24%  [.] user_group_updater::~user_group_updater
     0.34%     +0.20%  [.] sinsp_evt::get_param

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0450         +0.0450           148           155           148           155
BM_sinsp_split_median                                          +0.0425         +0.0425           149           155           149           155
BM_sinsp_split_stddev                                          +2.7763         +2.7773             1             3             1             3
BM_sinsp_split_cv                                              +2.6139         +2.6148             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1213         +0.1213            56            63            56            63
BM_sinsp_concatenate_paths_relative_path_median                +0.1192         +0.1192            56            63            56            63
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5897         -0.5890             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6341         -0.6334             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0034         -0.0034            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0036         -0.0036            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.7056         +0.7064             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.7115         +0.7123             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.1047         +0.1047            58            65            58            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.0969         +0.0969            59            65            59            65
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.0249         -0.0247             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.1173         -0.1171             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (ec8810c) to head (4b21b72).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2351   +/-   ##
=======================================
  Coverage   77.18%   77.19%           
=======================================
  Files         227      227           
  Lines       30194    30206   +12     
  Branches     4612     4619    +7     
=======================================
+ Hits        23306    23318   +12     
  Misses       6888     6888
Flag Coverage Δ
libsinsp 77.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP
FedeDP approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 15, 2025
@poiana
Copy link
Contributor

poiana commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 15, 2025

LGTM label has been added.

Git tree hash: 383a6f9a2c84d18510dba7d584f3a1e8af33b6d7

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 15, 2025
@poiana poiana merged commit a358970 into falcosecurity:master Apr 15, 2025
47 checks passed
@FedeDP
Copy link
Contributor

FedeDP commented Apr 15, 2025

/milestone 0.21.0

@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 15, 2025
@poiana poiana added this to the 0.21.0 milestone Apr 15, 2025
@ekoops ekoops deleted the ekoops/move-server-ports branch April 15, 2025 11:45
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/M
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @leogr