Skip to content

feat(userspace/libsinsp)!: pass references to *_to_string utils #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

feat(userspace/libsinsp)!: pass references to *_to_string utils #2349

merged 1 commit into from
Apr 15, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 15, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR modifies some *_to_string network utils to accepts references instead of raw pointers.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: pass references to `*_to_string` utils

@poiana poiana requested a review from hbrueckner April 15, 2025 08:36
@ekoops
feat(userspace/libsinsp)!: pass references to *_to_string utils
f4dd2b3 
BREAKING CHANGE: update `*_to_string` signatures

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana requested a review from Molter73 April 15, 2025 08:36
@ekoops ekoops force-pushed the ekoops/ref-to-string branch from 55ec1b7 to f4dd2b3 Compare April 15, 2025 08:36
@poiana poiana added the size/M label Apr 15, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     5.81%     -0.58%  [.] sinsp_evt::get_type
     2.68%     -0.36%  [.] sinsp_evt::load_params
     3.38%     +0.36%  [.] next_event_from_file
     2.27%     +0.31%  [.] gzfile_read
    35.88%     +0.29%  [.] sinsp_thread_manager::create_thread_dependencies
     6.34%     -0.28%  [.] sinsp_parser::reset
     5.54%     +0.27%  [.] sinsp::next
     0.38%     +0.26%  [.] sinsp_evt::get_param
     0.82%     +0.19%  [.] sinsp_evt_filter::sinsp_evt_filter
     1.53%     -0.19%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0074         +0.0074           150           151           150           151
BM_sinsp_split_median                                          +0.0104         +0.0104           149           151           149           151
BM_sinsp_split_stddev                                          +0.0290         +0.0298             1             1             1             1
BM_sinsp_split_cv                                              +0.0214         +0.0222             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1495         +0.1494            56            64            56            64
BM_sinsp_concatenate_paths_relative_path_median                +0.1476         +0.1476            56            64            56            64
BM_sinsp_concatenate_paths_relative_path_stddev                +3.6523         +3.6524             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +3.0474         +3.0476             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0051         -0.0051            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0061         -0.0061            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.2710         +0.2692             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.2775         +0.2757             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0941         +0.0941            60            65            60            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.0787         +0.0787            60            65            60            65
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.5564         +0.5553             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.4224         +0.4215             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.18%. Comparing base (9faea12) to head (f4dd2b3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/utils.cpp 85.71% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
- Coverage   77.19%   77.18%   -0.01%     
==========================================
  Files         227      227              
  Lines       30193    30194       +1     
  Branches     4610     4611       +1     
==========================================
  Hits        23306    23306              
- Misses       6887     6888       +1
Flag Coverage Δ
libsinsp 77.18% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP
FedeDP approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 15, 2025
@poiana
Copy link
Contributor

poiana commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 15, 2025

LGTM label has been added.

Git tree hash: 44217c5f3caaf5a6cc5fa76e5b9ad42c51499c91

@FedeDP
Copy link
Contributor

FedeDP commented Apr 15, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 15, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 15, 2025
@poiana poiana merged commit 42cf2c7 into falcosecurity:master Apr 15, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 15, 2025
@ekoops ekoops deleted the ekoops/ref-to-string branch April 15, 2025 08:58
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/M
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @leogr