Skip to content

feat(userspace/libsinsp)!: move large_envs_enabled into signature #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

feat(userspace/libsinsp)!: move large_envs_enabled into signature #2345

merged 1 commit into from
Apr 14, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 14, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It pass large_envs_enabled as `sinsp_treadinfo::set_env() parameter.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: move `large_envs_enabled` into signature

@poiana poiana requested review from hbrueckner and Molter73 April 14, 2025 10:41
@ekoops ekoops mentioned this pull request Apr 14, 2025
Open
25 tasks
@poiana poiana added the size/L label Apr 14, 2025
@ekoops ekoops force-pushed the ekoops/large-env branch from d6d70c4 to 03b5893 Compare April 14, 2025 10:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 14, 2025 •
edited
Loading

Perf diff from master - unit tests

     3.56%     +0.40%  [.] next_event_from_file
     2.47%     +0.38%  [.] gzfile_read
     1.18%     +0.36%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.99%     -0.35%  [.] sinsp_parser::process_event
     1.26%     -0.34%  [.] next
     6.19%     -0.32%  [.] sinsp::next
     6.20%     -0.31%  [.] sinsp_parser::reset
     1.21%     -0.22%  [.] std::_Hashtable<unsigned long, std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> >, std::allocator<std::pair<unsigned long const, std::shared_ptr<ppm_evt_hdr> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.51%     +0.18%  [.] sinsp_evt::get_direction
     5.27%     -0.18%  [.] sinsp_evt::get_type

Heap diff from master - unit tests

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: -8B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0092         -0.0092           149           148           149           148
BM_sinsp_split_median                                          -0.0114         -0.0114           149           148           149           148
BM_sinsp_split_stddev                                          -0.6605         -0.6595             1             0             1             0
BM_sinsp_split_cv                                              -0.6573         -0.6563             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1380         -0.1380            65            56            65            56
BM_sinsp_concatenate_paths_relative_path_median                -0.1358         -0.1358            65            56            65            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.6548         -0.6548             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5995         -0.5995             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0182         -0.0182            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0207         -0.0207            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.3342         +1.3319             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +1.3775         +1.3752             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1244         -0.1244            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.1255         -0.1255            64            56            64            56
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.3540         +1.3488             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.6884         +1.6824             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.07143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.19%. Comparing base (a5e675b) to head (bcc20ee).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/parsers.cpp 60.00% 2 Missing ⚠️
userspace/libsinsp/sinsp.cpp 66.66% 1 Missing ⚠️
userspace/libsinsp/thread_manager.cpp 0.00% 1 Missing ⚠️
userspace/libsinsp/threadinfo.cpp 97.77% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
+ Coverage   77.17%   77.19%   +0.01%     
==========================================
  Files         227      227              
  Lines       30188    30193       +5     
  Branches     4616     4610       -6     
==========================================
+ Hits        23299    23306       +7     
+ Misses       6889     6887       -2
Flag Coverage Δ
libsinsp 77.19% <91.07%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedeDP
Copy link
Contributor

FedeDP commented Apr 14, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 14, 2025
FedeDP
FedeDP previously approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 14, 2025
@poiana
Copy link
Contributor

poiana commented Apr 14, 2025

LGTM label has been added.

Git tree hash: a6a5825268e7194f91f2fc783380f2c0401770ce

@ekoops
feat(userspace/libsinsp)!: move large_envs_enabled into signature
bcc20ee 
Pass `large_envs_enabled` as `sinsp_treadinfo::set_env() parameter.

BREAKING CHANGE: update `sinsp_threadinfo::init()`,
`sinsp_threadinfo::set_env()` and parser constructor

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/large-env branch from 03b5893 to bcc20ee Compare April 14, 2025 12:53
@poiana poiana removed the lgtm label Apr 14, 2025
@poiana poiana requested a review from FedeDP April 14, 2025 12:53
FedeDP
FedeDP approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 14, 2025
@poiana
Copy link
Contributor

poiana commented Apr 14, 2025

LGTM label has been added.

Git tree hash: 0d0f5981652c5631954b2441360dbc70da7f8e5d

@poiana
Copy link
Contributor

poiana commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 14, 2025
@poiana poiana merged commit 9faea12 into falcosecurity:master Apr 14, 2025
46 of 47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 14, 2025
@ekoops ekoops deleted the ekoops/large-env branch April 14, 2025 14:04
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@Molter73 Molter73 Awaiting requested review from Molter73

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/L
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @FedeDP @poiana @leogr