Skip to content

feat(libsinsp)!: move fd filtering logic out of add_fd_from_scap #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

feat(libsinsp)!: move fd filtering logic out of add_fd_from_scap #2342

merged 1 commit into from
Apr 14, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 14, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It moves the add_fd_from_scap file descriptor filtering logic out of sinsp_threadinfo

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(libsinsp)!: move fd filtering logic out of `add_fd_from_scap`

@ekoops
feat(libsinsp)!: move fd filtering logic out of add_fd_from_scap
e84b910 
BREAKING CHANGE: update `add_fd_from_scap` signature

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@poiana poiana requested a review from hbrueckner April 14, 2025 08:15
@poiana poiana requested a review from jasondellaluce April 14, 2025 08:15
@poiana poiana added the size/L label Apr 14, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     6.65%     -0.63%  [.] sinsp::next
     3.97%     +0.32%  [.] sinsp_thread_manager::find_thread
     5.50%     +0.28%  [.] sinsp_evt::get_type
     1.77%     +0.27%  [.] sinsp_parser::process_event
     1.14%     +0.24%  [.] next
     2.55%     -0.23%  [.] gzfile_read
     1.38%     +0.22%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     4.05%     -0.19%  [.] next_event_from_file
     1.97%     -0.19%  [.] sinsp_thread_manager::get_thread_ref
     0.84%     -0.17%  [.] sinsp_parser::event_cleanup

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0186         -0.0186           149           146           149           146
BM_sinsp_split_median                                          -0.0140         -0.0141           149           147           149           147
BM_sinsp_split_stddev                                          +6.5583         +6.5500             0             3             0             3
BM_sinsp_split_cv                                              +6.7017         +6.6930             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0765         +0.0765            58            62            58            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0798         +0.0798            57            62            57            62
BM_sinsp_concatenate_paths_relative_path_stddev                -0.3564         -0.3577             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.4022         -0.4033             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0236         +0.0236            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   +0.0223         +0.0223            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +4.7071         +4.7177             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +4.5753         +4.5856             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0989         +0.0989            59            65            59            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.1077         +0.1078            59            65            59            65
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.0993         +1.0992             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.9104         +0.9103             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (d45ed9c) to head (e84b910).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2342   +/-   ##
=======================================
  Coverage   77.17%   77.18%           
=======================================
  Files         227      227           
  Lines       30192    30191    -1     
  Branches     4607     4610    +3     
=======================================
  Hits        23302    23302           
+ Misses       6890     6889    -1
Flag Coverage Δ
libsinsp 77.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops ekoops mentioned this pull request Apr 14, 2025
Open
25 tasks
@poiana poiana added the lgtm label Apr 14, 2025
@poiana
Copy link
Contributor

poiana commented Apr 14, 2025

LGTM label has been added.

Git tree hash: 7abf007b0f32b6512c513c9852b7bc9507e3446c

@FedeDP
Copy link
Contributor

FedeDP commented Apr 14, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 14, 2025
FedeDP
FedeDP approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 14, 2025
@poiana
Copy link
Contributor

poiana commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a5e675b into falcosecurity:master Apr 14, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 14, 2025
@ekoops ekoops deleted the ekoops/add-fd-from-scap branch April 14, 2025 12:49
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@gnosek gnosek

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/L
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @gnosek