Skip to content

feat(userspace/libsinsp)!: make sinsp::m_table_registry private #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

feat(userspace/libsinsp)!: make sinsp::m_table_registry private #2340

merged 1 commit into from
Apr 9, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Apr 9, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR unexposes sinsp::m_table_registry field.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: make `sinsp::m_table_registry` private

@poiana poiana requested review from hbrueckner and leogr April 9, 2025 12:02
@ekoops ekoops force-pushed the ekoops/unexpose-table-registry branch from aa3751e to fb4fdb0 Compare April 9, 2025 12:02
@ekoops
feat(userspace/libsinsp)!: make sinsp::m_table_registry private
63f2eb0 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/unexpose-table-registry branch from fb4fdb0 to 63f2eb0 Compare April 9, 2025 12:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Perf diff from master - unit tests

     9.64%     -3.73%  [.] sinsp_parser::reset
    34.35%     +1.85%  [.] sinsp_thread_manager::create_thread_dependencies
     7.84%     -1.78%  [.] sinsp::next
     3.73%     +0.60%  [.] sinsp_thread_manager::find_thread
     1.27%     +0.47%  [.] is_conversion_needed
     3.28%     +0.45%  [.] next_event_from_file
     2.25%     +0.36%  [.] gzfile_read
     1.37%     +0.33%  [.] sinsp_parser::process_event
     0.96%     +0.30%  [.] next
     2.17%     +0.23%  [.] sinsp_evt::load_params

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0051         +0.0050           148           149           148           149
BM_sinsp_split_median                                          +0.0059         +0.0057           148           149           148           149
BM_sinsp_split_stddev                                          -0.6561         -0.6562             1             0             1             0
BM_sinsp_split_cv                                              -0.6578         -0.6579             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0146         +0.0145            61            62            61            62
BM_sinsp_concatenate_paths_relative_path_median                +0.0440         +0.0438            61            64            61            64
BM_sinsp_concatenate_paths_relative_path_stddev                +7.4001         +7.4015             0             3             0             3
BM_sinsp_concatenate_paths_relative_path_cv                    +7.2793         +7.2817             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0321         -0.0322            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0286         -0.0287            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7267         -0.7264             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7176         -0.7173             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0013         +0.0012            66            66            66            66
BM_sinsp_concatenate_paths_absolute_path_median                -0.0008         -0.0009            66            66            66            66
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.3703         -0.3704             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.3712         -0.3712             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (5df36d4) to head (63f2eb0).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
- Coverage   77.18%   77.17%   -0.01%     
==========================================
  Files         227      227              
  Lines       30193    30198       +5     
  Branches     4611     4613       +2     
==========================================
+ Hits        23304    23306       +2     
- Misses       6889     6892       +3
Flag Coverage Δ
libsinsp 77.17% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP
FedeDP approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 9, 2025
@poiana
Copy link
Contributor

poiana commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Apr 9, 2025

LGTM label has been added.

Git tree hash: e981c1f1cbce0e8471188f2a5d8ece92131710a3

@poiana poiana added the approved label Apr 9, 2025
@FedeDP
Copy link
Contributor

FedeDP commented Apr 9, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 9, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 9, 2025
@poiana poiana merged commit d45ed9c into falcosecurity:master Apr 9, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 9, 2025
@ekoops ekoops deleted the ekoops/unexpose-table-registry branch April 9, 2025 13:56
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/feature New feature or request lgtm release-note size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @leogr