Skip to content

feat(userspace/libsinsp)!: unexpose sinsp's m_input_plugin* #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

feat(userspace/libsinsp)!: unexpose sinsp's m_input_plugin* #2316

merged 1 commit into from
Mar 18, 2025

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Mar 17, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR makes m_input_plugin and m_input_plugin_open_params instance variables private to sinsp instance.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: unexpose `sinsp`'s `m_input_plugin*`

@poiana poiana requested review from hbrueckner and incertum March 17, 2025 14:08
@ekoops
feat(userspace/libsinsp)!: unexpose sinsp's m_input_plugin*
2b6e0fd 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/private-input-plugin branch from 53b9c76 to 2b6e0fd Compare March 17, 2025 14:10
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     4.14%     -0.56%  [.] next_event_from_file
     8.80%     +0.46%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     5.73%     +0.35%  [.] sinsp::next
     6.02%     +0.28%  [.] sinsp_parser::reset
     9.76%     -0.27%  [.] sinsp_thread_manager::create_thread_dependencies
     1.21%     -0.24%  [.] next
     1.34%     -0.23%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     2.69%     +0.21%  [.] gzfile_read
     0.73%     +0.20%  [.] sinsp_evt::get_ts
     0.51%     -0.18%  [.] convert_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0067         +0.0067           143           144           143           144
BM_sinsp_split_median                                          +0.0087         +0.0088           143           144           143           144
BM_sinsp_split_stddev                                          -0.4365         -0.4348             2             1             2             1
BM_sinsp_split_cv                                              -0.4402         -0.4386             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0578         +0.0578            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0602         +0.0602            57            61            57            61
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1355         +0.1351             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    +0.0734         +0.0731             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0131         +0.0131            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0128         +0.0128            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.2481         +0.2499             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.2320         +0.2338             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0241         +0.0241            58            59            58            59
BM_sinsp_concatenate_paths_absolute_path_median                +0.0303         +0.0303            58            59            58            59
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.5335         +1.5334             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.4740         +1.4739             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (15c4369) to head (2b6e0fd).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2316   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files         224      224           
  Lines       30135    30135           
  Branches     4605     4605           
=======================================
  Hits        23254    23254           
  Misses       6881     6881
Flag Coverage Δ
libsinsp 77.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poiana poiana added the lgtm label Mar 17, 2025
@poiana
Copy link
Contributor

poiana commented Mar 17, 2025

LGTM label has been added.

Git tree hash: 7557197c2c30099effd749a45a5be864ae1f2a33

FedeDP
FedeDP approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Mar 18, 2025
@poiana
Copy link
Contributor

poiana commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Mar 18, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Mar 18, 2025
@poiana poiana merged commit 69501f6 into falcosecurity:master Mar 18, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Mar 18, 2025
@ekoops ekoops deleted the ekoops/private-input-plugin branch March 18, 2025 10:16
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnosek gnosek gnosek approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@incertum incertum Awaiting requested review from incertum

Assignees

@gnosek gnosek

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/feature New feature or request lgtm release-note size/S
Projects
Falco Roadmap
Archived in project
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @gnosek