Skip to content

chore(libsinsp): reduce max proc lookup number log severity #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore(libsinsp): reduce max proc lookup number log severity #2166

merged 1 commit into from
Nov 20, 2024

Conversation

deepskyblue86
Copy link
Member

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area libsinsp

Does this PR require a change in the driver versions?

What this PR does / why we need it:
Lower Reached max process/socket lookup number log severity.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@deepskyblue86
chore(libsinsp): reduce max proc lookup number log severity
08c0cb2 
Signed-off-by: Angelo Puglisi <angelopuglisi86@gmail.com>
@deepskyblue86 deepskyblue86 force-pushed the chore/reached-max-proc-lookup-loglevel branch from bfa6540 to 08c0cb2 Compare November 20, 2024 10:41
FedeDP
FedeDP approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Nov 20, 2024
@poiana
Copy link
Contributor

poiana commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 20, 2024

LGTM label has been added.

Git tree hash: 33daa8cae2177d10f5f3c7ca6ac4dda2c47f4e98

@FedeDP
Copy link
Contributor

FedeDP commented Nov 20, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Nov 20, 2024
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     8.15%     +1.13%  [.] sinsp_parser::reset
     3.49%     +0.93%  [.] gzfile_read
     3.23%     -0.60%  [.] sinsp_thread_manager::find_thread
     5.59%     +0.56%  [.] sinsp_evt::get_type
     2.00%     -0.53%  [.] sinsp::fetch_next_event
     0.57%     +0.47%  [.] sinsp_threadinfo::~sinsp_threadinfo
     0.67%     +0.44%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     3.96%     -0.40%  [.] next
     2.51%     -0.37%  [.] libsinsp::sinsp_suppress::process_event
     0.16%     +0.34%  [.] scap_file_test_helpers::capture_search_evt_by_num

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0087         +0.0087           140           141           140           141
BM_sinsp_split_median                                          +0.0096         +0.0095           140           141           140           141
BM_sinsp_split_stddev                                          +0.0716         +0.0715             2             2             2             2
BM_sinsp_split_cv                                              +0.0623         +0.0622             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0917         +0.0917            58            63            58            63
BM_sinsp_concatenate_paths_relative_path_median                +0.0853         +0.0853            58            63            58            63
BM_sinsp_concatenate_paths_relative_path_stddev                +1.9143         +1.9146             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.6696         +1.6698             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0087         +0.0087            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0083         +0.0083            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0079         -0.0060             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.0164         -0.0146             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0747         +0.0747            56            60            56            60
BM_sinsp_concatenate_paths_absolute_path_median                +0.0735         +0.0735            56            60            56            60
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.7970         +2.7989             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +2.5330         +2.5347             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0203         +0.0203           389           396           389           396
BM_sinsp_split_container_image_median                          +0.0220         +0.0220           388           397           388           397
BM_sinsp_split_container_image_stddev                          -0.2270         -0.2273             3             3             3             3
BM_sinsp_split_container_image_cv                              -0.2424         -0.2426             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (512f9b7) to head (08c0cb2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
userspace/libsinsp/threadinfo.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2166   +/-   ##
=======================================
  Coverage   74.77%   74.77%           
=======================================
  Files         254      254           
  Lines       33505    33505           
  Branches     5747     5747           
=======================================
  Hits        25054    25054           
  Misses       8451     8451
Flag Coverage Δ
libsinsp 74.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@poiana poiana merged commit bb7cf06 into falcosecurity:master Nov 20, 2024
47 of 49 checks passed
@deepskyblue86 deepskyblue86 deleted the chore/reached-max-proc-lookup-loglevel branch November 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

@LucaGuerra LucaGuerra

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup lgtm release-note-none size/XS
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@deepskyblue86 @poiana @FedeDP @jasondellaluce @LucaGuerra