Skip to content

chore(e2e): fix e2e build without bundled deps #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore(e2e): fix e2e build without bundled deps #2136

merged 1 commit into from
Nov 5, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

Does this PR require a change in the driver versions?

What this PR does / why we need it:

When compiling without bundled deps the e2e sinsp tests failed because gtest is not a dependency. Example of cmake variables provided

"CMAKE_BUILD_TYPE": "Release",
"BUILD_BPF": "ON",
"BUILD_DRIVER": "ON",
"USE_BUNDLED_DEPS": "OFF",
"MODERN_BPF_DEBUG_MODE": "ON",
"BUILD_LIBSCAP_MODERN_BPF": "ON",
"BUILD_LIBSCAP_GVISOR": "OFF",
"CREATE_TEST_TARGETS": "ON",
"USE_BUNDLED_VALIJSON": "ON",
"USE_BUNDLED_OPENSSL": "ON",
"USE_BUNDLED_RE2": "ON",
"USE_BUNDLED_LIBBPF": "ON",
"SCAP_FILES_SUITE_ENABLE": "ON",
"BUILD_WARNINGS_AS_ERRORS": "Off",
"ENABLE_DRIVERS_TESTS": "ON",
"ENABLE_LIBSCAP_TESTS": "ON",
"ENABLE_LIBSINSP_E2E_TESTS": "ON"

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97
chore(e2e): fix e2e build without bundled deps
58532ad 
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
@Andreagit97 Andreagit97 added this to the 0.19.0 milestone Oct 30, 2024
@poiana poiana added the size/XS label Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (0ec8bac) to head (58532ad).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2136   +/-   ##
=======================================
  Coverage   74.46%   74.46%           
=======================================
  Files         254      254           
  Lines       33333    33333           
  Branches     5721     5738   +17     
=======================================
  Hits        24820    24820           
- Misses       8490     8513   +23     
+ Partials       23        0   -23
Flag Coverage Δ
libsinsp 74.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     4.19%     +1.10%  [.] next
     7.10%     +0.69%  [.] sinsp::next
     3.61%     +0.65%  [.] sinsp_parser::process_event
     0.11%     +0.62%  [.] sinsp_container_manager::resolve_container
     1.36%     -0.62%  [.] 0x00000000000ea3b0
     4.61%     -0.62%  [.] sinsp_evt::load_params
     2.17%     -0.60%  [.] scap_event_decode_params
     0.85%     -0.45%  [.] sinsp_threadinfo::sinsp_threadinfo
     4.03%     -0.42%  [.] gzfile_read
     0.46%     +0.40%  [.] std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, true> > >::_M_deallocate_nodes

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0216         -0.0216           153           150           153           150
BM_sinsp_split_median                                          -0.0216         -0.0216           153           150           153           150
BM_sinsp_split_stddev                                          -0.2782         -0.2785             2             1             2             1
BM_sinsp_split_cv                                              -0.2623         -0.2626             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0182         +0.0182            59            60            59            60
BM_sinsp_concatenate_paths_relative_path_median                +0.0158         +0.0158            59            60            59            60
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5445         -0.5448             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5526         -0.5530             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0555         -0.0555            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0538         -0.0538            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.2471         -0.2475             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.2028         -0.2033             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0850         +0.0850            59            64            59            64
BM_sinsp_concatenate_paths_absolute_path_median                +0.0850         +0.0850            59            64            59            64
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.2284         -0.2311             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.2889         -0.2913             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0095         -0.0095           396           392           396           392
BM_sinsp_split_container_image_median                          -0.0111         -0.0112           396           392           396           392
BM_sinsp_split_container_image_stddev                          -0.3805         -0.3803             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.3746         -0.3744             0             0             0             0

FedeDP
FedeDP approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 30, 2024
@poiana
Copy link
Contributor

poiana commented Oct 30, 2024

LGTM label has been added.

Git tree hash: 50114427efd1ecf42e84b562bc0ba0f77b350fc7

@poiana
Copy link
Contributor

poiana commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 39c0e0d into falcosecurity:master Nov 5, 2024
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/build dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/XS
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Andreagit97 @poiana @leogr @FedeDP