Skip to content

fix(ci): avoid create comment workflows failing when required worfklows did not run #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix(ci): avoid create comment workflows failing when required worfklows did not run #2121

merged 2 commits into from
Oct 21, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 17, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Avoids all the failings like: https://github.com/falcosecurity/libs/actions/workflows/create-comment-kernel-testing.yml

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP added 2 commits October 17, 2024 15:07
@FedeDP
fix(ci): fixed create-comment-kernel-testing workflow when kernel-tes…
b1b6f2b 
…ting CI does not run.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
fix(ci): fixed create-comment-perf workflow when perf CI does not run.
0f74fd1 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 17, 2024

Wip while i test it.

@poiana poiana added the size/M label Oct 17, 2024
@poiana poiana requested review from hbrueckner and mstemm October 17, 2024 13:10
FedeDP
FedeDP commented Oct 17, 2024
View reviewed changes
.github/workflows/create-comment-kernel-testing.yml
return artifact.name == "pr-kernel-testing"
})[0];
});
if (matchArtifacts == null) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matching artifacts will be found when required workflows did not actually run (ie: drivers_ci got skipped)

FedeDP
FedeDP commented Oct 17, 2024
View reviewed changes
.github/workflows/create-comment-kernel-testing.yml
@@ -36,7 +40,10 @@ jobs:
fs.writeFileSync('${{github.workspace}}/pr.zip', Buffer.from(download.data));

- name: 'Unpack artifact'
run: unzip pr.zip
run:
if [ -f pr.zip ]; then
Copy link
Contributor Author

@FedeDP FedeDP Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if pr.zip was downloaded by previous step.

FedeDP
FedeDP commented Oct 17, 2024
View reviewed changes
.github/workflows/create-comment-kernel-testing.yml
@@ -45,6 +52,9 @@ jobs:
# Taken from https://github.com/actions/github-script/blob/main/.github/workflows/pull-request-test.yml
script: |
var fs = require('fs');
if (!fs.existsSync('./NR')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no NR file, then no artifact was downloaded. Leave.

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 17, 2024

CI failed because it is still using master workflow unfortunately: https://github.com/falcosecurity/libs/actions/runs/11385651715/job/31675996706

We will need to test this by merging :D

@FedeDP FedeDP changed the title wip: fix(ci): avoid create comment workflows failing when required worfklows did not run fix(ci): avoid create comment workflows failing when required worfklows did not run Oct 17, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 17, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 17, 2024
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     3.25%     +1.24%  [.] gzfile_read
     3.37%     +1.18%  [.] sinsp_evt::load_params
     7.93%     -1.13%  [.] sinsp::next
    10.16%     -0.88%  [.] sinsp_parser::reset
     0.85%     -0.48%  [.] sinsp_split[abi:cxx11]
     2.77%     +0.48%  [.] sinsp_thread_manager::find_thread
     0.91%     -0.44%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     0.98%     -0.40%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Identity, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::find
     2.77%     +0.39%  [.] sinsp_thread_manager::get_thread_ref
     5.16%     +0.36%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0084         -0.0084           154           153           154           153
BM_sinsp_split_median                                          -0.0099         -0.0099           154           153           154           153
BM_sinsp_split_stddev                                          +0.5808         +0.5821             1             2             1             2
BM_sinsp_split_cv                                              +0.5941         +0.5955             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0132         +0.0132            56            57            56            57
BM_sinsp_concatenate_paths_relative_path_median                +0.0124         +0.0123            56            57            56            57
BM_sinsp_concatenate_paths_relative_path_stddev                +0.1634         +0.1660             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.1483         +0.1509             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0007         -0.0007            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0006         -0.0006            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0854         -0.0855             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.0847         -0.0848             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0028         -0.0028            57            56            57            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.0047         -0.0047            57            56            57            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.0536         -0.0542             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.0510         -0.0516             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0040         -0.0040           397           395           397           395
BM_sinsp_split_container_image_median                          -0.0062         -0.0062           398           395           398           395
BM_sinsp_split_container_image_stddev                          +0.2121         +0.2123             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.2170         +0.2172             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (8177641) to head (0f74fd1).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2121   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31915    31915           
  Branches     5620     5625    +5     
=======================================
  Hits        23521    23521           
- Misses       8373     8386   +13     
+ Partials       21        8   -13
Flag Coverage Δ
libsinsp 73.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Andreagit97
Andreagit97 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Oct 17, 2024
@poiana
Copy link
Contributor

poiana commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3216d09 into master Oct 21, 2024
48 of 49 checks passed
@poiana poiana deleted the fix/create_comment_workflows branch October 21, 2024 07:49
@FedeDP FedeDP mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

@Andreagit97 Andreagit97

Labels
approved area/CI dco-signoff: yes kind/cleanup lgtm release-note-none size/M
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @leogr @Andreagit97