Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2024

Bumps actions/upload-pages-artifact from 2.0.0 to 3.0.1.

Release notes

Sourced from actions/upload-pages-artifact's releases.

v3.0.1

Changelog

See details of all code changes since previous release.

v3.0.0

Changelog

To deploy a GitHub Pages site which has been uploaded with this version of actions/upload-pages-artifact, you must also use actions/deploy-pages@v4 or newer.

⚠️ For use with products other than GitHub.com, such as GitHub Enterprise Server, please be aware that this new Actions artifacts service is not yet supported in the latest GHES release at this time.

See details of all code changes since previous release.

Commits
  • 56afc60 Merge pull request #94 from SilverRainZ/main
  • d12fdfb Merge branch 'main' into main
  • aef5542 Merge pull request #88 from uiolee/patch-1
  • 29cedd7 Merge branch 'main' into patch-1
  • a69c22e Merge pull request #92 from actions/dependabot/github_actions/non-breaking-ch...
  • 794e304 Group tar's output to prevent it from messing up logs
  • 14007f6 Bump the non-breaking-changes group with 1 update
  • 0191170 Merge pull request #91 from actions/dependabot-grouping
  • 0e7832d Update Dependabot config to group non-breaking changes
  • 1a6d9fa Update README.md
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
NONE

Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 2.0.0 to 3.0.1.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@a753861...56afc60)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 9, 2024
@poiana poiana added the size/XS label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Perf diff from master - unit tests

     6.16%     +1.08%  [.] sinsp::next
    11.05%     -0.84%  [.] sinsp_parser::reset
     3.30%     -0.76%  [.] sinsp_thread_manager::find_thread
     1.43%     -0.67%  [.] libsinsp::events::is_unknown_event
     0.40%     +0.63%  [.] scap_event_has_large_payload
     4.50%     -0.60%  [.] sinsp_parser::process_event
     3.90%     +0.58%  [.] sinsp_evt::load_params
     1.30%     -0.52%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     4.22%     +0.46%  [.] next
     1.88%     +0.45%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0155         +0.0155           153           155           153           155
BM_sinsp_split_median                                          +0.0139         +0.0139           153           155           153           155
BM_sinsp_split_stddev                                          +0.1029         +0.1038             1             2             1             2
BM_sinsp_split_cv                                              +0.0860         +0.0869             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0165         -0.0165            63            62            63            62
BM_sinsp_concatenate_paths_relative_path_median                -0.0127         -0.0127            63            63            63            63
BM_sinsp_concatenate_paths_relative_path_stddev                +1.3244         +1.3243             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +1.3633         +1.3633             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0473         -0.0473            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0438         -0.0438            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8076         -0.8063             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7981         -0.7967             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0399         +0.0399            61            64            61            64
BM_sinsp_concatenate_paths_absolute_path_median                +0.0596         +0.0596            61            64            61            64
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.5200         -0.5201             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.5384         -0.5385             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0032         +0.0032           396           397           396           397
BM_sinsp_split_container_image_median                          +0.0023         +0.0023           396           397           396           397
BM_sinsp_split_container_image_stddev                          -0.5246         -0.5243             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.5262         -0.5258             0             0             0             0

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (e117af4) to head (b60a45c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31914    31914           
  Branches     5631     5611   -20     
=======================================
+ Hits        23519    23520    +1     
+ Misses       8385     8364   -21     
- Partials       10       30   +20     
Flag Coverage Δ
libsinsp 73.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana
Copy link
Contributor

poiana commented Oct 9, 2024

LGTM label has been added.

Git tree hash: c6871b294694459a7b524498de70c684eca10cf9

@FedeDP
Copy link
Contributor

FedeDP commented Oct 10, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 10, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 9513cea into master Oct 10, 2024
49 checks passed
@poiana poiana deleted the dependabot/github_actions/actions/upload-pages-artifact-3.0.1 branch October 10, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants