Skip to content

fix(userspace/libscap): avoid a possible read past end of buffer. #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

fix(userspace/libscap): avoid a possible read past end of buffer. #2401

merged 1 commit into from
May 10, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 9, 2025

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area libscap-engine-source-plugin

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
fix(userspace/libscap): avoid a possible read past end of buffer.
2d917d1 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana requested review from gnosek and hbrueckner May 9, 2025 14:00
FedeDP
FedeDP commented May 9, 2025
View reviewed changes
userspace/libscap/engine/source_plugin/source_plugin.c
@@ -206,10 +206,6 @@ static int32_t next(struct scap_engine_handle engine,
// Sanity checks in case a plugin implements a non-syscall event source.
// If a plugin has event sourcing capability and has a specific ID, then
// it is allowed to produce only plugin events of its own event source.
uint8_t* pplugin_id = (uint8_t*)evt + sizeof(scap_evt) + sizeof(uint32_t) + sizeof(uint32_t);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we don't yet know if this is a pluginevent, thus we cannot read nothing (we are not sure what we are reading)

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone May 9, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2025

/cc @LucaGuerra

@poiana poiana requested a review from LucaGuerra May 9, 2025 14:01
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

Perf diff from master - unit tests

    34.56%     +0.56%  [.] sinsp_thread_manager::create_thread_dependencies
     4.74%     +0.21%  [.] sinsp_parser::reset
     4.18%     -0.19%  [.] sinsp_thread_manager::find_thread
     0.63%     -0.18%  [.] sinsp_parser::parse_context_switch
     1.39%     -0.18%  [.] user_group_updater::~user_group_updater
     1.46%     +0.18%  [.] is_conversion_needed
     1.87%     -0.17%  [.] sinsp_parser::process_event
     1.46%     -0.15%  [.] user_group_updater::user_group_updater
     0.86%     -0.14%  [.] sinsp_evt::get_ts
     6.55%     +0.14%  [.] sinsp::next

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0105         +0.0104           148           150           148           150
BM_sinsp_split_median                                          +0.0103         +0.0102           148           150           148           150
BM_sinsp_split_stddev                                          +0.2297         +0.2298             1             1             1             1
BM_sinsp_split_cv                                              +0.2169         +0.2171             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1466         +0.1465            56            64            56            64
BM_sinsp_concatenate_paths_relative_path_median                +0.1398         +0.1398            56            64            56            64
BM_sinsp_concatenate_paths_relative_path_stddev                +3.5418         +3.5450             0             1             0             1
BM_sinsp_concatenate_paths_relative_path_cv                    +2.9609         +2.9641             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0282         -0.0283            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0269         -0.0270            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8376         -0.8374             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8329         -0.8327             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0932         +0.0931            59            65            59            65
BM_sinsp_concatenate_paths_absolute_path_median                +0.0831         +0.0830            59            64            59            64
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.0562         +2.0559             1             2             1             2
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.7958         +1.7957             0             0             0             0

@codecov Codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (b1b10ef) to head (2d917d1).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2401   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files         227      227           
  Lines       30323    30323           
  Branches     4644     4644           
=======================================
  Hits        23429    23429           
  Misses       6894     6894
Flag Coverage Δ
libsinsp 77.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@poiana poiana added the lgtm label May 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Andreagit97
Andreagit97 approved these changes May 10, 2025
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap May 10, 2025
@poiana
Copy link
Contributor

poiana commented May 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6c5659b into master May 10, 2025
48 checks passed
@poiana poiana deleted the fix/avoid_possible_read_past_end_of_buffer branch May 10, 2025 10:59
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap May 10, 2025
@FedeDP FedeDP mentioned this pull request May 12, 2025
Merged
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaGuerra LucaGuerra LucaGuerra approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@gnosek gnosek Awaiting requested review from gnosek

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@LucaGuerra LucaGuerra

@Andreagit97 Andreagit97

Labels
approved area/libscap-engine-source-plugin dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/S
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @poiana @LucaGuerra @Andreagit97