fix(userspace/libsinsp): not report container id as host on failed lookups #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okups Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
|
cc @Andreagit97 |
Andreagit97
approved these changes
Dec 22, 2023
|
LGTM label has been added. Git tree hash: e9478f953ee656983b6baed5860a8dfade666687
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jan 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
On failed container info lookups, the container ID stored in each thread info can potentially be marked as empty. However, the
container.idfield currently reports empty container IDs ashostvalue, thus making impossible to distinguish actual threads running on the host from threads running in containers for which the metadata lookup failed.This attempts mitigating the issue by also checking that the thread is running outside of a namespace for
container.id. As such, failed container ID lookups will return an empty string instead ofhost.Special notes for your reviewer:
Does this PR introduce a user-facing change?: