Skip to content

Feat: Add support for S3 index storage backend #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2024
Merged

Feat: Add support for S3 index storage backend #611

merged 1 commit into from
Jul 24, 2024

Conversation

brennoo
Copy link
Contributor

@brennoo brennoo commented Jul 23, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

This PR is adding support for S3 as storage backend for indexes

Fixes #606

Special notes for your reviewer:

@brennoo
Add support for S3 index storage backend
15ab1fb 
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
@poiana poiana requested review from FedeDP and loresuso July 23, 2024 14:46
@poiana poiana added the size/L label Jul 23, 2024
@alacuku
Copy link
Member

alacuku commented Jul 23, 2024

Hi @brennoo, thanks for the PR.
Does the aws SDK support the authentication with third-party tools? Or the index file in the bucket has to be public?

@brennoo
Copy link
Contributor Author

brennoo commented Jul 23, 2024

Hi @brennoo, thanks for the PR. Does the aws SDK support the authentication with third-party tools? Or the index file in the bucket has to be public?

hi there, thanks for looking into it

no need to be public - I tested the auth from a k8s pod via IRSA and on my local using AWS_ACCESS_* envvars and it works

alacuku
alacuku approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana poiana added the lgtm label Jul 24, 2024
@poiana
Copy link
Contributor

poiana commented Jul 24, 2024

LGTM label has been added.

Git tree hash: c85cbdefe27e65ce893ec6c449f5ab227dfd3f92

@poiana
Copy link
Contributor

poiana commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, brennoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 228cb06 into falcosecurity:main Jul 24, 2024
17 checks passed
@brennoo brennoo deleted the feat/add_index_s3_backend branch July 24, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alacuku alacuku alacuku approved these changes

@FedeDP FedeDP Awaiting requested review from FedeDP

@loresuso loresuso Awaiting requested review from loresuso

Assignees

@alacuku alacuku

Labels
approved area/library dco-signoff: yes kind/feature lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for S3 index storage backend
3 participants
@brennoo @alacuku @poiana