Skip to content

feat(auth/basic): extend auth basic command #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jun 17, 2024

Username and password can be set using cli flags, env variables and stdin.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

This PR extends the falcoctl registry auth basic command by allowing username and password to be set using the cli flags, env variables and stdin other than the interactive prompt.

See examples:

Example - Log in with username and password from command line flags:
	falcoctl registry auth basic -u username -p password localhost:5000
Example - Login with username and password from env variables:
	FALCOCTL_REGISTRY_AUTH_BASIC_USERNAME=username FALCOCTL_REGISTRY_AUTH_BASIC_PASSWORD=password falcoctl registry auth basic localhost:5000
Example - Login with username and password from stdin:
	falcoctl registry auth basic -u username --password-stdin localhost:5000
Example - Login with username and password in an interactive prompt:
	falcoctl registry auth basic localhost:5000

Which issue(s) this PR fixes:

Fixes #
#134

Special notes for your reviewer:

Username and password can be set using cli flags, env variables and stdin.

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@alacuku alacuku force-pushed the kcl/extend-login-cmd branch from 4e2efb0 to f80f024 Compare June 17, 2024 09:27
@leogr leogr requested a review from FedeDP June 17, 2024 09:47
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jun 17, 2024

LGTM label has been added.

Git tree hash: cbefdaab61971415c1b540509596091cfb3d0bc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants