Skip to content

fix(pusher): correctly report artifact type #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Feb 13, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:

This PR fixes the push command that does not report the artifact type pushed to the registry.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@alacuku alacuku force-pushed the kcl/fix-pusher-output branch from 914a2d2 to 8064d80 Compare February 13, 2024 09:29
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 13, 2024

LGTM label has been added.

Git tree hash: 13d52e482c05c61cfef482b41d41d77632f5e600

@FedeDP
Copy link
Contributor

FedeDP commented Feb 13, 2024

/milestone v0.8.0

@poiana poiana added this to the v0.8.0 milestone Feb 13, 2024
@poiana poiana merged commit 43f1d3c into falcosecurity:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants