Skip to content

fix: Dead link in PR template #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

krnowak
Copy link
Contributor

@krnowak krnowak commented Feb 7, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Fixes a dead link to contributing docs.

@poiana
Copy link
Contributor

poiana commented Feb 7, 2024

Welcome @krnowak! It looks like this is your first PR to falcosecurity/falcoctl 🎉

@poiana poiana added the size/XS label Feb 7, 2024
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Great catch, thanks!

@poiana
Copy link
Contributor

poiana commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, krnowak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Feb 7, 2024

LGTM label has been added.

Git tree hash: 6e85ae35361e0e5248987f8039a2b3e9e932fa70

@poiana poiana added the approved label Feb 7, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Feb 7, 2024

/milestone v0.8.0

@poiana poiana added this to the v0.8.0 milestone Feb 7, 2024
@poiana poiana merged commit d3dbcbd into falcosecurity:main Feb 7, 2024
@krnowak krnowak deleted the krnowak/link-fix branch February 7, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants