feat: adding support for KMS in cosign #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
cpanato
reviewed
Feb 3, 2024
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
915ec06 to
c34d042
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brennoo, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: ca58e416c2d4dcfed1cbe48966c0fe28a98d5ae4
|
|
/hold for tests |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
This PR adds support for KMS providers in the cosign signature verify process, making it possible to use cloud providers KMS, hashicorp vault and kubernetes.
Which issue(s) this PR fixes:
Fixes #380
Special notes for your reviewer:
I've tested
keyparameter with different values includinghttp://,awskms://and local filepubkey.pem- it was needed to add theprivate-infrastructureflag for cases where the transaction is not sent to the transparency log