Remove check on stable PHP versions from dashboard widget logic #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Fragen <andy@thefragens.com>
|
Essentially passing the data back to core's logic of what to display. |
|
That looks right to me, but I want to defer to Ryan. |
Ipstenu
reviewed
Jun 9, 2025
| return [ | ||
| // If we're on the stable or secure branches, the recommended version | ||
| // If we're on the security branches, the recommended version |
There was a problem hiding this comment.
Part of me wants to check for stable, but as an info ... MVP. We can do that kind of thing later with a 'contact your host...'
There was a problem hiding this comment.
From what I see in core, any PHP version listed as stable is fine as long as it's on the current minor, not latest.
There was a problem hiding this comment.
Yeah that's why it's a later thing :) We can do better. Like if you're 20 patch releases out of date, warn you.
rmccue
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Removes check on a
stablePHP version to allow a pass-through to the remaining logic. The result is that anyone on a stable PHP version will not see the PHP Update Warning dashboard widget.