Skip to content

Conversation

TeemuSuoranta
Copy link
Contributor

There are issue preventing localization of some strings:

  • References to text-domain git-updater-lite
  • Usage of localization with context that doesn't use _x() function

There are two references of strings without text-domain but those exist in core translations so are ok to use

Signed-off-by: Teemu Suoranta <teemu.suoranta@evermade.fi>
Copy link

@bitfactory-robin-martijn bitfactory-robin-martijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joedolson
Copy link
Member

Thank you, @TeemuSuoranta!

@joedolson joedolson merged commit d15b9ff into fairpm:main Jun 8, 2025
1 check passed
@rmccue rmccue added this to the 0.3.0 milestone Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants