Fix the documented type and default value of MetadataDocument::$sections.
#193
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: costdev <79332690+costdev@users.noreply.github.com>
|
Alternatively, if this is always going to be treated as an associative array in the plugin, we could cast it to an array when it's received. |
rmccue
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documented type of
MetadataDocument::$sectionsisstring[]and it's defaulted to an empty array.However, the value as received is actually an object, per the related section of the spec. While this is cast to an array in various other parts of the codebase, the documentation in
MetadataDocumentshould match the actual value.This PR changes the documented type to
stdClassand removes the default value.