Ping IndexNow for newly 404ing URLs. #160
Conversation
Signed-off-by: Peter Wilson <git-commit-by@peterwilson.cc>
d14f180 to
a701299
Compare
There was a problem hiding this comment.
LGTM!
For reference, as I did just verify, the FAQ on https://www.indexnow.org/faq explicitly states that pinging with newly 404ing URLs to get them removed is fine, so this is a solid improvement.
Signed-off-by: Ryan McCue <me@ryanmccue.info>
|
I've checked the PHPCS failures, they're happening in an unrelated file. FWIW, in the implementation for my site (very heavily based on this code), I also removed the revision and autosave check to allow |
|
I got this wrong. The newly 404ing URLs don't use the correct permalink as it returns the plain version, ie example.com/?p=1234. I'm figuring it all out in a plugin to account for various use cases. Including tests. https://github.com/peterwilsoncc/no-fuss-indexnow |
This reverts commit 966c829.
Modifies the conditions under which IndexNow is pinged.
Why
In the event someone has accidentally published a page and then unpublished it, it's likely they wish to have the URL removed from search engines asap.
How
Replaces the check for
'publish' !== $new_statuswith a check whether the old and new post statuses are publicly viewable.If both are not viewable no ping takes place as the URL will be an existing 404 response.
If one is viewable but the other is not, a ping takes place as the page has either being updated or unpublished.
As sites can have custom public post statuses, I've removed the hard coded
publishstatus check asis_post_status_viewable()will cover a wider range of statuses, includingpublish.No ping takes place for non-viewable post types as the it shouldn't change without developer intervention, at which point they are responsible for the SEO impacts of the change.
For item 2: Bypass pinging if
'1' == $_GET['meta-box-loader']Fixes #158.