✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	25fd17b
🔍 Latest deploy log	https://app.netlify.com/projects/fakerjs/deploys/6861ae67b9c8a30008e06cdc
😎 Deploy Preview	https://deploy-preview-3538.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (a53d5a3) to head (25fd17b).

@@           Coverage Diff           @@
##             next    #3538   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2880     2880           
  Lines      220510   220510           
  Branches      952      951    -1     
=======================================
+ Hits       220455   220457    +2     
+ Misses         55       53    -2     

I get why this is happening and why the extra test works "as expected" - but doesn't that basically mean that the const in the maybe() generic is basically doing nothing.

faker/src/modules/helpers/index.ts

Line 767 in b174135

maybe<const TResult>(

From my understanding the const clause (don't know if that is the right term) can never be meat in this specific scenario.

it has a different behavior for e.g. arrays
see other tests below

it has a different behavior for e.g. arrays

That's true. But I'm talking about this specific case. The generic is inferring a return type of a function that is passed in. The function itself could be inferred as const by typescript. But the return type can never as it. itself would need to statically refer to it's return type as const, from my understanding. That's also what you showed by the second test.

Anyways, my question was regarding the implementation of the maybe method, not the test that is being fixed here. So I'm merging this.