-
-
Notifications
You must be signed in to change notification settings - Fork 1k
infra: stop using node 18 #3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3536 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2888 2888
Lines 222112 222112
Branches 951 949 -2
=======================================
Hits 222059 222059
Misses 53 53 🚀 New features to boost your workflow:
|
Shinigami92
commented
Jun 29, 2025
ejcheng
previously approved these changes
Jun 30, 2025
9d703e2
to
a21ba5f
Compare
Update index.md
a21ba5f
to
9cdc780
Compare
xDivisionByZerox
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not touch user facing code, but only removes node 18 pipelines and allows to update the rimraf package which is only internally used anyway.
The only prepared used facing change was made to the guide and tells the user to use at least node 20, but this PR does not yet remove node 18 support, as tsup still targets node 18.