Skip to content

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jun 28, 2025

This PR does not touch user facing code, but only removes node 18 pipelines and allows to update the rimraf package which is only internally used anyway.
The only prepared used facing change was made to the guide and tells the user to use at least node 20, but this PR does not yet remove node 18 support, as tsup still targets node 18.

@Shinigami92 Shinigami92 self-assigned this Jun 28, 2025
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 28, 2025 09:52
@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jun 28, 2025
Copy link

netlify bot commented Jun 28, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9cdc780
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6866ae671d761a000860162e
😎 Deploy Preview https://deploy-preview-3536.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (a4886ee) to head (9cdc780).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3536   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2888     2888           
  Lines      222112   222112           
  Branches      951      949    -2     
=======================================
  Hits       222059   222059           
  Misses         53       53           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92 Shinigami92 requested a review from a team June 28, 2025 09:58
This was referenced Jun 29, 2025
@xDivisionByZerox xDivisionByZerox added this to the v10.0 milestone Jun 29, 2025
ejcheng
ejcheng previously approved these changes Jun 30, 2025
@Shinigami92 Shinigami92 force-pushed the infra-stop-using-node-18 branch from 9d703e2 to a21ba5f Compare July 1, 2025 21:31
Update index.md
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Jul 4, 2025
Merged via the queue into next with commit 660871e Jul 4, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the infra-stop-using-node-18 branch July 4, 2025 11:54
@Shinigami92 Shinigami92 linked an issue Jul 4, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Node v18 Support
4 participants