Skip to content

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265.

Normalize the entries in the internet module definitions in all locales. No entries have been removed. The changes are sorting only, with the exception of locales/base/user-agent.ts where the comments have been restored manually.

How to verify

Checkout the branch:

git switch refactor/normalize-internet-data

The branch contains two commits. One that changes the script to include the internet module being part of the normalization and one that actually updates the files.
By restoring files before the normalization happened and running it yourself, you should see the same state as this PR provides:

git checkout HEAD~1 . 
# or use the index directly
# git checkout 0edf2979f .

# since git checkout changes are always stages, they need to be brought to the work-tree
git restore --staged .

pnpm run preflight
# or only run the necessary scripts
# pnpm run generate:locales && pnpm run test:update-snapshots

You should end up with the only changes being the manual comment in the locales/base/user-agent.ts files, as mentioned on top.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: internet Something is referring to the internet module labels May 4, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 4, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team May 4, 2025 12:41
@xDivisionByZerox xDivisionByZerox self-assigned this May 4, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner May 4, 2025 12:41
Copy link

netlify bot commented May 4, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 090e613
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/68191cba90c19d0008239c15
😎 Deploy Preview https://deploy-preview-3502.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (aa98867) to head (090e613).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3502      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2880     2880              
  Lines      220746   219937     -809     
  Branches      951      952       +1     
==========================================
- Hits       220693   219884     -809     
  Misses         53       53              
Files with missing lines Coverage Δ
src/locales/af_ZA/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/az/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/az/internet/free_email.ts 100.00% <100.00%> (ø)
src/locales/base/internet/emoji.ts 100.00% <ø> (ø)
src/locales/base/internet/jwt_algorithm.ts 100.00% <100.00%> (ø)
src/locales/base/internet/user_agent_pattern.ts 100.00% <100.00%> (ø)
src/locales/cs_CZ/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/cs_CZ/internet/free_email.ts 100.00% <100.00%> (ø)
src/locales/da/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/de/internet/domain_suffix.ts 100.00% <100.00%> (ø)
... and 81 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox merged commit e6151e4 into next May 5, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the refactor/normalize-internet-data branch May 5, 2025 20:47
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants