Skip to content

feat(locale): extended list of colors in Polish #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2025
Merged

feat(locale): extended list of colors in Polish #3586

merged 3 commits into from
Aug 11, 2025

Conversation

pkuczynski
Copy link
Member

@pkuczynski pkuczynski requested a review from a team as a code owner August 5, 2025 10:54
@pkuczynski pkuczynski self-assigned this Aug 5, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 5, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 7915c98
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/689a550e1ede8f00083b74d1
😎 Deploy Preview https://deploy-preview-3586.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov Codecov
Copy link

codecov bot commented Aug 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (e631f6e) to head (7915c98).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #3586    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2894     2894            
  Lines      222262   222397   +135     
  Branches      931      930     -1     
========================================
+ Hits       222195   222330   +135     
  Misses         67       67
Files with missing lines Coverage Δ
src/locales/pl/color/human.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ejcheng ejcheng requested a review from a team August 11, 2025 09:12
xDivisionByZerox
xDivisionByZerox approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: color Something is referring to the color module c: feature Request for new feature labels Aug 11, 2025
@xDivisionByZerox xDivisionByZerox changed the title feat: extended list of colors in Polish feat(locale): extended list of colors in Polish Aug 11, 2025
@xDivisionByZerox xDivisionByZerox added this to the v10.0 milestone Aug 11, 2025
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Aug 11, 2025
Merged via the queue into next with commit 9940d54 Aug 11, 2025
30 checks passed
@xDivisionByZerox xDivisionByZerox deleted the feat/pl/colors branch August 11, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@pkuczynski pkuczynski

Labels
c: feature Request for new feature c: locale Permutes locale definitions m: color Something is referring to the color module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pkuczynski @Shinigami92 @ejcheng @xDivisionByZerox