Skip to content

refactor(locale): remove invalid credit card issuer patterns #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 13, 2025
Merged

refactor(locale): remove invalid credit card issuer patterns #3568

merged 9 commits into from
Aug 13, 2025

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner July 16, 2025 18:11
@xDivisionByZerox xDivisionByZerox self-assigned this Jul 16, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 83ff896
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/689cd4d11d57e700078d99e3
😎 Deploy Preview https://deploy-preview-3568.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Jul 16, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (9940d54) to head (83ff896).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3568   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2894     2894           
  Lines      222397   222385   -12     
  Branches      930      927    -3     
=======================================
- Hits       222330   222318   -12     
  Misses         67       67
Files with missing lines Coverage Δ
src/locales/el/finance/credit_card/discover.ts 100.00% <100.00%> (ø)
src/locales/en/finance/credit_card/diners_club.ts 100.00% <100.00%> (ø)
src/locales/en/finance/credit_card/discover.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox
Copy link
Member Author

Is this a

  • c: test (since that is the requirement of the issue)
  • c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs (since run time is changed due to locale changes)
  • c: locale Permutes locale definitions (because locale data is changed)
  • c: bug Something isn't working (because invalid patterns have been removed)

?

@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Jul 16, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team July 16, 2025 18:20
@Shinigami92
Copy link
Member

Is this a


  • c: test
    (since that is the requirement of the issue)

  • c: refactor
    PR that affects the runtime behavior, but doesn't add new features or fixes bugs
    (since run time is changed due to locale changes)

  • c: locale
    Permutes locale definitions
    (because locale data is changed)

  • c: bug
    Something isn't working
    (because invalid patterns have been removed)

?

you touched src, so it cannot be a c: test.
could be a c: refactor or c: bug + c: locale

Shinigami92
Shinigami92 reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except this suggestion, LGTM

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Jul 16, 2025
matthewmayer
matthewmayer reviewed Jul 16, 2025
View reviewed changes
matthewmayer
matthewmayer reviewed Jul 16, 2025
View reviewed changes
@xDivisionByZerox xDivisionByZerox changed the title test(finance): add case for credit card issuer pattern validation refactor(locale): remove invalid credit card issuer patterns Aug 11, 2025
@xDivisionByZerox xDivisionByZerox added the c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs label Aug 11, 2025
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v10.0 Aug 13, 2025
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Aug 13, 2025
Merged via the queue into next with commit 9783d95 Aug 13, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the 2350-test-all-credit-card-issuer-patterns branch August 13, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.

Verify all credit card issuer patterns are valid with validator.js
3 participants
@xDivisionByZerox @Shinigami92 @matthewmayer