infra: more precise engines field #3561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3561 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2888 2888
Lines 221958 221958
Branches 931 929 -2
==========================================
- Hits 221891 221889 -2
- Misses 67 69 +2 🚀 New features to boost your workflow:
|
Shinigami92
approved these changes
Jul 6, 2025
xDivisionByZerox
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a more precise engines field
https://nodejs.org/api/modules.html#loading-ecmascript-modules-using-require
This ensures, for example, that a developer using Node 22.0.0 will receive a warning if they attempt to install v10 so they can bump their version to v22.13+