-
-
Notifications
You must be signed in to change notification settings - Fork 1k
refactor!: remove deprecations #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0fb9a1
to
10c8983
Compare
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3553 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2888 2888
Lines 222112 221958 -154
Branches 952 927 -25
==========================================
- Hits 222059 221889 -170
- Misses 53 69 +16
🚀 New features to boost your workflow:
|
1bbc823
to
c648f68
Compare
There is also the deprecation of faker/src/modules/helpers/eval.ts Lines 138 to 139 in 4e422f7
Also, see these "deprecated" parts that add additional JS support that where aimed to be removed in v10:
|
Oh it seems you missed the workaround for "userName" in the documentation component: Lines 72 to 81 in 4e422f7
|
tbh I currently don't know "how" to resolve this Edit: nevermind, now I got it... |
I just searched for |
18bf5a0
to
66a5504
Compare
66a5504
to
c5516bc
Compare
51837ac
to
dfc58e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one more 🙂
Or, not...
No description provided.