Skip to content

Conversation

Shinigami92
Copy link
Member

This PR utilizes git clean https://git-scm.com/docs/git-clean which is usable in any environment.
Benefits:

  1. we don't need rimraf at all anymore
  2. no untracked files get missed, because git knows what is in .gitignore

I switched already to this strategy in some private and some company projects, and it is working really well 👍
Also if we someday need to exclude anything from the command, it is possible to use --exclude (which I also use for e.g. *.local so some local untracked env files wont get removed in a company project)

@Shinigami92 Shinigami92 added this to the vAnytime milestone Jun 29, 2025
@Shinigami92 Shinigami92 self-assigned this Jun 29, 2025
@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jun 29, 2025
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 29, 2025 14:25
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 9c5da9b
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6861964a4a91b900085491e1
😎 Deploy Preview https://deploy-preview-3541.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Shinigami92 Shinigami92 requested a review from a team June 29, 2025 14:26
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (1dfb8f2) to head (9c5da9b).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3541   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2880     2880           
  Lines      220510   220510           
  Branches      953      953           
=======================================
  Hits       220457   220457           
  Misses         53       53           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox dismissed their stale review June 29, 2025 15:12

I wanted to comment, not approve

@Shinigami92 Shinigami92 force-pushed the infra-utilize-git-clean branch from d3c52ac to d9ce7be Compare June 29, 2025 15:19
@Shinigami92 Shinigami92 force-pushed the infra-utilize-git-clean branch from d9ce7be to 0e3845f Compare June 29, 2025 16:15
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) June 29, 2025 19:44
@Shinigami92 Shinigami92 disabled auto-merge June 29, 2025 19:46
@Shinigami92 Shinigami92 merged commit b174135 into next Jun 29, 2025
23 checks passed
@Shinigami92 Shinigami92 deleted the infra-utilize-git-clean branch June 29, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants